sacc, branch HEAD

Avoid zero-length iowrite

2024-03-19T21:52:09Z

commit 20a51bafd3906aa0337fe221d0981293d94370a5 parent 21d46d603a3697f04072e4c0edb0076b4a215a2e Author: Michael Forney Date: Tue, 19 Mar 2024 14:52:09 -0700 Avoid zero-length iowrite iowrite with bs==0 results in either a zero-length write() or tls_write(). The former is unspecified by POSIX[0]: > If nbyte is zero and the file is not a regular file, the results > are unspecified. The latter is not explicitly disallowed by tls_write(3), but libressl implements tls_write with a call to SSL_write, which is documented to have undefined behavior[1]: > When calling SSL_write() with num=0 bytes to be sent, the behaviour > is undefined. [0] https://pubs.opengroup.org/onlinepubs/9699919799/functions/write.html [1] https://man.openbsd.org/SSL_write.3

fix plumber for T type

2024-02-03T10:30:50Z

commit 21d46d603a3697f04072e4c0edb0076b4a215a2e parent 4fe03eaa05536aac1704b92c0267fb099125a3a3 Author: Hiltjo Posthuma Date: Sat, 3 Feb 2024 11:30:50 +0100 fix plumber for T type

Show correct (gopher) URLs for menuentries pointing to HTML files.

2024-01-28T14:25:55Z

commit 4fe03eaa05536aac1704b92c0267fb099125a3a3 parent d70616c357a135b8e251fe1974cf88f529dbc67f Author: Julian Schweinsberg Date: Sun, 28 Jan 2024 15:25:55 +0100 Show correct (gopher) URLs for menuentries pointing to HTML files. Only the 'h'tml links providing an external URI (prefixed with "URL:") should be printed directly. Otherwise print the link like any other gopher link. Example for a menu pointing to HTML files in the real world: gopher://gopher.metafilter.com/1/MetaFilter

Release version 1.07

2023-07-31T20:01:45Z

commit d70616c357a135b8e251fe1974cf88f529dbc67f parent 5b9bcbd0dcf3cf2c4edb995621de245ce6b80a9d Author: Quentin Rameau Date: Mon, 31 Jul 2023 22:01:45 +0200 Release version 1.07

tls: Fix a crash on invalid cert in non-interactive mode

2023-01-18T22:52:32Z

commit 5b9bcbd0dcf3cf2c4edb995621de245ce6b80a9d parent 4003310026b26f9c81b44fb07686e7301064c4bf Author: Hiltjo Posthuma Date: Wed, 18 Jan 2023 23:52:32 +0100 tls: Fix a crash on invalid cert in non-interactive mode This is because uiprompt() cannot be used in non-interactive. To reproduce: Put a different certificate in ~/.share/sacc/cert/bitreich.org Then run: sacc gophers://bitreich.org > /tmp/plop

tls: Fix local certificates path

2022-10-30T22:19:42Z

commit 4003310026b26f9c81b44fb07686e7301064c4bf parent 68934acac9cff7b2b6e1ee42cb2dd912341c0f5c Author: eidolon Date: Sun, 30 Oct 2022 18:19:42 -0400 tls: Fix local certificates path

ui_ti: Revert line jump change commited by mistake

2022-10-17T19:48:02Z

commit 68934acac9cff7b2b6e1ee42cb2dd912341c0f5c parent c3638488ce9b1d5d23e33f292710a35d14a6cc72 Author: Quentin Rameau Date: Mon, 17 Oct 2022 21:48:02 +0200 ui_ti: Revert line jump change commited by mistake Those lines added in 392dcb24732c88f500266b923bafdda8eb631220 where for testing and not supposed to stay.

man: Add TLS description

2022-10-15T21:19:06Z

commit c3638488ce9b1d5d23e33f292710a35d14a6cc72 parent 8b2a2eaf79da098717fe9a7d87fca9fa1f6c6579 Author: Quentin Rameau Date: Sat, 15 Oct 2022 23:19:06 +0200 man: Add TLS description Thanks to Hiltjo for the suggestion!

tls: Fix certificate path length calculation

2022-10-15T21:10:38Z

commit 8b2a2eaf79da098717fe9a7d87fca9fa1f6c6579 parent 9dec9b200c1bddd6d12f4aa6b43e2c329f513235 Author: Quentin Rameau Date: Sat, 15 Oct 2022 23:10:38 +0200 tls: Fix certificate path length calculation Thanks to Hiltjo for spotting this!

tls: Handle local certificate path

2022-10-15T10:50:09Z

commit 9dec9b200c1bddd6d12f4aa6b43e2c329f513235 parent 392dcb24732c88f500266b923bafdda8eb631220 Author: Quentin Rameau Date: Sat, 15 Oct 2022 12:50:09 +0200 tls: Handle local certificate path Although I believe that every computer should have a user "quinq", use "~/share/sacc/cert" path by default for looking up certificates. Also, let the user override this default with the environment variable SACC_CERT_DIR.

io: Use defines instead of constants

2022-09-20T21:30:55Z

commit 392dcb24732c88f500266b923bafdda8eb631220 parent e8930420e7c31a3cea0484314bd38aba5197fa39 Author: Quentin Rameau Date: Tue, 20 Sep 2022 23:30:55 +0200 io: Use defines instead of constants

tls: Add support for TOFU (Trusted On First Use)

2022-09-20T21:04:00Z

commit e8930420e7c31a3cea0484314bd38aba5197fa39 parent 7d3b71e31c73e122b62fec68a7196586f1b93082 Author: Quentin Rameau Date: Tue, 20 Sep 2022 23:04:00 +0200 tls: Add support for TOFU (Trusted On First Use)

tls: Refactor code

2022-09-11T22:22:30Z

commit 7d3b71e31c73e122b62fec68a7196586f1b93082 parent b567fedfe014dc5c795b5bc8703bc187efd13e27 Author: Quentin Rameau Date: Mon, 12 Sep 2022 00:22:30 +0200 tls: Refactor code

Makefile: Add NetBSD compile flags

2022-07-20T21:30:14Z

commit b567fedfe014dc5c795b5bc8703bc187efd13e27 parent 6b0f1c92c58fcff0de4724a1c005264e86794244 Author: Quentin Rameau Date: Wed, 20 Jul 2022 23:30:14 +0200 Makefile: Add NetBSD compile flags

common: Move gopher type enum out of common header

2022-07-20T21:27:03Z

commit 6b0f1c92c58fcff0de4724a1c005264e86794244 parent cf707964fe31a4987713b4ae89eea96e63640c6a Author: Quentin Rameau Date: Wed, 20 Jul 2022 23:27:03 +0200 common: Move gopher type enum out of common header

Makefile: Generate version only once

2022-07-20T18:47:34Z

commit cf707964fe31a4987713b4ae89eea96e63640c6a parent 572915c3d29428773577739e54647c4dfd0daa5d Author: Quentin Rameau Date: Wed, 20 Jul 2022 20:47:34 +0200 Makefile: Generate version only once

Makefile: Refine header build dependencies

2022-07-20T18:25:37Z

commit 572915c3d29428773577739e54647c4dfd0daa5d parent 239ecedf18b5fdb0650a1b5468d2b75de2a38731 Author: Quentin Rameau Date: Wed, 20 Jul 2022 20:25:37 +0200 Makefile: Refine header build dependencies

Makefile: Add default build flags

2022-07-20T18:14:26Z

commit 239ecedf18b5fdb0650a1b5468d2b75de2a38731 parent 0e5be464cdcab2d17d9f9ab5cf75015bd18c1632 Author: Quentin Rameau Date: Wed, 20 Jul 2022 20:14:26 +0200 Makefile: Add default build flags

Makefile: Add system compilation flags

2022-07-20T18:07:55Z

commit 0e5be464cdcab2d17d9f9ab5cf75015bd18c1632 parent edb683070a46f17242618569dacff02b6075115e Author: Quentin Rameau Date: Wed, 20 Jul 2022 20:07:55 +0200 Makefile: Add system compilation flags

ui_txt: fix a crash while searching

2022-07-06T17:17:36Z

commit edb683070a46f17242618569dacff02b6075115e parent c29025f3cc818b8e0f43d41d9a7d4b3220503cfa Author: Hiltjo Posthuma Date: Wed, 6 Jul 2022 19:17:36 +0200 ui_txt: fix a crash while searching Reproducable with an empty search string when using '/'. Reported by pi31415 on IRC in #gopherproject, thanks!

ui_txt: fix forgotten continue in switch

2022-07-06T17:17:36Z

commit c29025f3cc818b8e0f43d41d9a7d4b3220503cfa parent 69ee789f16787da6a3065d911a44fc7d4991e366 Author: Hiltjo Posthuma Date: Wed, 6 Jul 2022 19:17:36 +0200 ui_txt: fix forgotten continue in switch

man: Add version

2022-04-10T22:13:25Z

commit 69ee789f16787da6a3065d911a44fc7d4991e366 parent b2b6ca98bae9bac2b36cb4a13f66adaf876743aa Author: Quentin Rameau Date: Mon, 11 Apr 2022 00:13:25 +0200 man: Add version

Document and fix sacc version

2022-04-10T22:04:42Z

commit b2b6ca98bae9bac2b36cb4a13f66adaf876743aa parent df1d4c0a7b17bd56c27d3805c8316aab21d1c19d Author: Quentin Rameau Date: Mon, 11 Apr 2022 00:04:42 +0200 Document and fix sacc version

Release version 1.06

2022-04-10T21:50:22Z

commit df1d4c0a7b17bd56c27d3805c8316aab21d1c19d parent 64be22d4516d31613a4a2c4a4a746c7076b1bfab Author: Quentin Rameau Date: Sun, 10 Apr 2022 23:50:22 +0200 Release version 1.06

Document and fix sacc version

2022-04-10T22:04:42Z

commit 64be22d4516d31613a4a2c4a4a746c7076b1bfab parent 1f9509a7c5ab03ab79d64212113bd83f194dcbcb Author: Quentin Rameau Date: Mon, 11 Apr 2022 00:04:42 +0200 Document and fix sacc version

fix compilation without TLS support enabled in config.mk

2022-03-27T11:21:25Z

commit 1f9509a7c5ab03ab79d64212113bd83f194dcbcb parent cb05caeda420012e03188d8f2cde8b80a166aeb1 Author: Hiltjo Posthuma Date: Sun, 27 Mar 2022 13:21:25 +0200 fix compilation without TLS support enabled in config.mk Clear the struct cnx so no extra #ifdef for USE_TLS is needed.

ui_ti: add support for more DEC function keys

2022-03-27T11:30:25Z

commit cb05caeda420012e03188d8f2cde8b80a166aeb1 parent b4f6ed2bf2344c5717523313bc666eb297a6fe36 Author: Hiltjo Posthuma Date: Sun, 27 Mar 2022 13:30:25 +0200 ui_ti: add support for more DEC function keys This makes these keys work on a default configured urxvt and putty.

ui_ti: refactor DEC function key handling a bit for an upcoming commit

2022-03-27T11:28:02Z

commit b4f6ed2bf2344c5717523313bc666eb297a6fe36 parent 100d8ae55fc598a2c898bd6b5d33e15f131cee0c Author: Hiltjo Posthuma Date: Sun, 27 Mar 2022 13:28:02 +0200 ui_ti: refactor DEC function key handling a bit for an upcoming commit No functional change intended.

ui_ti: add application key support

2022-03-27T11:22:50Z

commit 100d8ae55fc598a2c898bd6b5d33e15f131cee0c parent b15d084107da05069a3cf70cd81475f26d8e563e Author: Hiltjo Posthuma Date: Sun, 27 Mar 2022 13:22:50 +0200 ui_ti: add application key support This is a sequence like ESC O A (arrow key in application key mode). This is a default mode in some terminals, like the terminal in HaikuOS. It makes the arrow keys work nicely.

Ignore SIGCHLD to prevent zombie processes for non-modal plumbing

2022-03-27T09:47:44Z

commit b15d084107da05069a3cf70cd81475f26d8e563e parent edbf8409a1e281d17422e7b12b5edd3832b4429d Author: Hiltjo Posthuma Date: Sun, 27 Mar 2022 11:47:44 +0200 Ignore SIGCHLD to prevent zombie processes for non-modal plumbing In config.h, when modalplumber = 0 is set (the default), sacc does not wait(2) on the process when a child process exits and it then becomes a zombie on Linux.

Release version 1.05

2021-11-28T14:29:13Z

commit edbf8409a1e281d17422e7b12b5edd3832b4429d parent c2e060c906af4fd970cb2b9ee2e3c05c83db1582 Author: Quentin Rameau Date: Sun, 28 Nov 2021 15:29:13 +0100 Release version 1.05

Add yank feature to sacc

2021-11-13T11:34:01Z

commit c2e060c906af4fd970cb2b9ee2e3c05c83db1582 parent e80d8bfc3241d197f387a7cbe40ec924853bdc83 Author: Quentin Rameau Date: Sat, 13 Nov 2021 12:34:01 +0100 Add yank feature to sacc Thanks to adc (Anders Damsgaard ) and Evil_Bob (Hiltjo Posthuma ) for their suggestions, patches, and peer pressure.

Make plumb function a generic execuri function

2021-11-13T10:43:16Z

commit e80d8bfc3241d197f387a7cbe40ec924853bdc83 parent 55a9e8d63e4a4ab5188eacbee3ef48f0170f7230 Author: Quentin Rameau Date: Sat, 13 Nov 2021 11:43:16 +0100 Make plumb function a generic execuri function

config: Declare variable only where actually needed

2021-11-08T23:26:41Z

commit 55a9e8d63e4a4ab5188eacbee3ef48f0170f7230 parent 5c2c788d7cda17dfadca2d12738792be1b140387 Author: Quentin Rameau Date: Tue, 9 Nov 2021 00:26:41 +0100 config: Declare variable only where actually needed

Remove unused variable / labels

2021-11-08T23:14:12Z

commit 5c2c788d7cda17dfadca2d12738792be1b140387 parent 6b520eb8b70b98a311a13a62606567095af28290 Author: Quentin Rameau Date: Tue, 9 Nov 2021 00:14:12 +0100 Remove unused variable / labels

Mark prototypes as extern in common.h

2021-11-08T23:13:45Z

commit 6b520eb8b70b98a311a13a62606567095af28290 parent 575c12bd0606717a2e7312669decc9a8197e41bd Author: Quentin Rameau Date: Tue, 9 Nov 2021 00:13:45 +0100 Mark prototypes as extern in common.h

Make some internal symbols static

2021-11-08T22:53:41Z

commit 575c12bd0606717a2e7312669decc9a8197e41bd parent 6272b9a65812c9f653d693941b3317fe2f98a028 Author: Quentin Rameau Date: Mon, 8 Nov 2021 23:53:41 +0100 Make some internal symbols static

Do not null-terminate strings printed by snprintf

2021-11-08T22:44:06Z

commit 6272b9a65812c9f653d693941b3317fe2f98a028 parent 89d3a0bd06d2345ffa98675e356a17be24a61210 Author: Quentin Rameau Date: Mon, 8 Nov 2021 23:44:06 +0100 Do not null-terminate strings printed by snprintf

Factorize URI formatting into sacc.c

2021-11-08T22:21:44Z

commit 89d3a0bd06d2345ffa98675e356a17be24a61210 parent ed632c2c8f6b6c64acda2883a04a2739ebf3cf0f Author: Quentin Rameau Date: Mon, 8 Nov 2021 23:21:44 +0100 Factorize URI formatting into sacc.c

Release version 1.04

2021-10-10T21:08:23Z

commit ed632c2c8f6b6c64acda2883a04a2739ebf3cf0f parent 1bd2e5661b9c3646a8ddf2862eadf766666f52c6 Author: Quentin Rameau Date: Sun, 10 Oct 2021 23:08:23 +0200 Release version 1.04

Add escapeinsert to the LICENSE file

2021-10-10T21:17:12Z

commit 1bd2e5661b9c3646a8ddf2862eadf766666f52c6 parent cd9b3f4f082f0581942db3a1ecdc2bf520416ad9 Author: Quentin Rameau Date: Sun, 10 Oct 2021 23:17:12 +0200 Add escapeinsert to the LICENSE file

Explain the name

2021-10-10T21:12:25Z

commit cd9b3f4f082f0581942db3a1ecdc2bf520416ad9 parent 69f77f767e52e21b1a40182d03180da73f2f9021 Author: Quentin Rameau Date: Sun, 10 Oct 2021 23:12:25 +0200 Explain the name

Add an ident version string to the binary

2021-10-10T21:04:06Z

commit 69f77f767e52e21b1a40182d03180da73f2f9021 parent 12b8b8a338d1791ce2d200f7cad99c9f0b5804d1 Author: Quentin Rameau Date: Sun, 10 Oct 2021 23:04:06 +0200 Add an ident version string to the binary This lets users get the current binary version using what(1) in an automated way.

Add modal plumber

2021-10-02T19:19:30Z

commit 12b8b8a338d1791ce2d200f7cad99c9f0b5804d1 parent 7e0793d8395184b5b21ecdd0b13bccb524d1e414 Author: escapeinsert Date: Sat, 2 Oct 2021 15:19:30 -0400 Add modal plumber With this option activated, sacc will wait for the plumber to return before continuing its execution.

Retry cleartext connection in case TLS failed

2021-04-11T15:12:00Z

commit 7e0793d8395184b5b21ecdd0b13bccb524d1e414 parent 4aa1ecfaf6c97cb02c7e34c88cc67c070b600b67 Author: Quentin Rameau Date: Sun, 11 Apr 2021 17:12:00 +0200 Retry cleartext connection in case TLS failed

Fix code style

2021-04-10T16:26:58Z

commit 4aa1ecfaf6c97cb02c7e34c88cc67c070b600b67 parent aa35a9899f7ce8e67a4801ff131d0cf96f7dc37c Author: Quentin Rameau Date: Sat, 10 Apr 2021 18:26:58 +0200 Fix code style

Make sighandler() static

2021-04-10T16:06:10Z

commit aa35a9899f7ce8e67a4801ff131d0cf96f7dc37c parent 031f781dfa1e657a9c9eb6677d78de4d82c455b1 Author: Quentin Rameau Date: Sat, 10 Apr 2021 18:06:10 +0200 Make sighandler() static

Export diag() function

2021-04-10T16:21:58Z

commit 031f781dfa1e657a9c9eb6677d78de4d82c455b1 parent 5a5611b3293eaac0b26832a54b845c6822736b65 Author: Quentin Rameau Date: Sat, 10 Apr 2021 18:21:58 +0200 Export diag() function

TLS: use wrapper functions

2021-04-10T13:56:05Z

commit 5a5611b3293eaac0b26832a54b845c6822736b65 parent e3535c1405eac56a658886023b057944b4b91bc0 Author: Quentin Rameau Date: Sat, 10 Apr 2021 15:56:05 +0200 TLS: use wrapper functions

Check for errors with expected -1 instead of < 0

2021-04-09T22:42:08Z

commit e3535c1405eac56a658886023b057944b4b91bc0 parent 92394502830c460c78633f56a69da4ce5f01d5fa Author: Quentin Rameau Date: Sat, 10 Apr 2021 00:42:08 +0200 Check for errors with expected -1 instead of < 0

Add TLS support

2021-04-09T21:58:34Z

commit 92394502830c460c78633f56a69da4ce5f01d5fa parent a58414c67ddf05ff48b8a86fb2d3cf5e58cea4b9 Author: Quentin Rameau Date: Fri, 9 Apr 2021 23:58:34 +0200 Add TLS support TLS will be used when a gophers:// URL is requested.

Remove separator in text UI status

2021-07-04T21:52:54Z

commit a58414c67ddf05ff48b8a86fb2d3cf5e58cea4b9 parent 80db85ac77a36eb3f591ea7f38816b6339607821 Author: Quentin Rameau Date: Sun, 4 Jul 2021 23:52:54 +0200 Remove separator in text UI status

Let the user configure the displayed menu items

2018-08-13T09:08:36Z

commit 80db85ac77a36eb3f591ea7f38816b6339607821 parent 0cb0ce0bb84aca55dd9d66d22fd6550ee0a58ada Author: Quentin Rameau Date: Mon, 13 Aug 2018 11:08:36 +0200 Let the user configure the displayed menu items

LICENSE: update authors

2021-06-23T20:33:51Z

commit 0cb0ce0bb84aca55dd9d66d22fd6550ee0a58ada parent b35d9b876df14d24dcd3e6fc98222b75955d0f6b Author: Quentin Rameau Date: Wed, 23 Jun 2021 22:33:51 +0200 LICENSE: update authors

man: fix and add some highlights

2021-06-23T20:26:46Z

commit b35d9b876df14d24dcd3e6fc98222b75955d0f6b parent 356726d76e8d082d6702401bbd6bffea47a84b1f Author: Quentin Rameau Date: Wed, 23 Jun 2021 22:26:46 +0200 man: fix and add some highlights

man: clarify a bit pager handling

2021-06-23T20:22:36Z

commit 356726d76e8d082d6702401bbd6bffea47a84b1f parent 8c49538793ad14ace0230ada9f4fb5f0c951ba32 Author: Quentin Rameau Date: Wed, 23 Jun 2021 22:22:36 +0200 man: clarify a bit pager handling

ui_ti: keep the current line when resizing

2021-05-28T17:13:36Z

commit 8c49538793ad14ace0230ada9f4fb5f0c951ba32 parent 0573022ce4ceab92394c35c5701abe061f2ec35a Author: Quentin Rameau Date: Fri, 28 May 2021 19:13:36 +0200 ui_ti: keep the current line when resizing Previously the current line would change to fit in the new screen size. Instead, change the current screen offset to keep the current line on screen.

reset SIGWINCH when spawning a child program for displaying text items

2021-05-26T14:18:22Z

commit 0573022ce4ceab92394c35c5701abe061f2ec35a parent eae2a995544b2b48c3a7debcb186a00aa0c400b3 Author: Hiltjo Posthuma Date: Wed, 26 May 2021 16:18:22 +0200 reset SIGWINCH when spawning a child program for displaying text items When opening a text item in the pager such as less and then resizing the terminal it would garble/overwrite the terminal output because sacc was redrawn.

Always restore terminal mode in TUI cleanup

2021-03-22T17:44:01Z

commit eae2a995544b2b48c3a7debcb186a00aa0c400b3 parent 6582965f7a534eb82339208980582fcb661fe7c3 Author: Quentin Rameau Date: Mon, 22 Mar 2021 18:44:01 +0100 Always restore terminal mode in TUI cleanup Thanks to Hiltjo for spotting that

Fix a memory leak on TUI window resize

2021-03-21T15:15:55Z

commit 6582965f7a534eb82339208980582fcb661fe7c3 parent 17674fcc4257afa53e81fdeab49b21f0f57528c7 Author: Quentin Rameau Date: Sun, 21 Mar 2021 16:15:55 +0100 Fix a memory leak on TUI window resize Memory is allocated by setupterm, which is called on window resizing for setting new values for lines and cols. Thanks to Hiltjo for spotting that!

Close connection when a single-dot line is read

2021-02-08T21:59:52Z

commit 17674fcc4257afa53e81fdeab49b21f0f57528c7 parent 34fd4f17068b408353bb6ae1df3eb4a58c259e25 Author: Quentin Rameau Date: Mon, 8 Feb 2021 22:59:52 +0100 Close connection when a single-dot line is read This approach instead of always warning that something might have been wrong in case the message isn't terminated single-dot line is more forgiving as not all gopher server follow that aspect of the standard.

Check that non-binary types end with ".\r\n"

2021-01-30T18:44:16Z

commit 34fd4f17068b408353bb6ae1df3eb4a58c259e25 parent cd386e712b7587740115c0fb0815a43052758ae2 Author: Quentin Rameau Date: Sat, 30 Jan 2021 19:44:16 +0100 Check that non-binary types end with ".\r\n" Otherwise that means that the remote end send incomplete data. Thanks to jhumphrey for spotting that!

mbsprint: fix character encoding errors handling

2021-01-24T13:53:06Z

commit cd386e712b7587740115c0fb0815a43052758ae2 parent 0a5b9f60e25411cf2fbd6688e8be5a7326f2b28d Author: Quentin Rameau Date: Sun, 24 Jan 2021 14:53:06 +0100 mbsprint: fix character encoding errors handling We were not advancing the input string correctly in case of error. Now we do that and print in a slightly more unified way. Send remarks to Hiltjo@melikenobugs.tk

xreallocarray: remove unuseful const parameters

2021-01-24T13:53:40Z

commit 0a5b9f60e25411cf2fbd6688e8be5a7326f2b28d parent edab539b23594219bbfc83729822da917a18a243 Author: Quentin Rameau Date: Sun, 24 Jan 2021 14:53:40 +0100 xreallocarray: remove unuseful const parameters

mbsprint: improve printing output when it has invalid UTF data

2021-01-05T20:21:03Z

commit edab539b23594219bbfc83729822da917a18a243 parent c416c8c73d0a33eb8c428b1a9b9eaaffc098ee5b Author: Hiltjo Posthuma Date: Tue, 5 Jan 2021 21:21:03 +0100 mbsprint: improve printing output when it has invalid UTF data Reset the decode state when mbtowc returns -1. The OpenBSD mbtowc(3) man page says: "If a call to mbtowc() resulted in an undefined internal state, mbtowc() must be called with s set to NULL to reset the internal state before it can safely be used again." Print the UTF replacement character (codepoint 0xfffd) for the invalid codepoint or incomplete sequence and continue printing the line (instead of stopping). Remove the 0 return code as it can't happen because we're already checking the string length in the loop.

sacc.1: Document use of PAGER environment variable

2020-12-03T17:30:27Z

commit c416c8c73d0a33eb8c428b1a9b9eaaffc098ee5b parent fe6bd5b52afc219737bd22f94ec3d679ac624de3 Author: Quentin Rameau Date: Thu, 3 Dec 2020 18:30:27 +0100 sacc.1: Document use of PAGER environment variable Thanks to vigoux for the hint.

ui_ti: replace manual padding with clr_eol

2020-09-26T15:14:45Z

commit fe6bd5b52afc219737bd22f94ec3d679ac624de3 parent c0a79c0424a99180ed4c79e3335dc3f7ced2322c Author: Quentin Rameau Date: Sat, 26 Sep 2020 17:14:45 +0200 ui_ti: replace manual padding with clr_eol Thanks to Marcin and Hiltjo for the hint!

ui_ti: explicitly define VMIN and VTIME values for read()

2020-08-19T20:57:57Z

commit c0a79c0424a99180ed4c79e3335dc3f7ced2322c parent f1432f5a5c56bad44485d9dee8fe92e6d09e1f4c Author: Hiltjo Posthuma Date: Wed, 19 Aug 2020 22:57:57 +0200 ui_ti: explicitly define VMIN and VTIME values for read() VMIN represents the minimum number of bytes that should be received when the read(2) function successfully returns. VTIME is a timer of 0.1 second granularity that is used to time out bursty and short term data transmissions. On some systems VMIN is not 1 causing input processing issues.

popen: remove close-on-exec flag to increase portability a bit

2020-07-02T21:26:09Z

commit f1432f5a5c56bad44485d9dee8fe92e6d09e1f4c parent 62d746cb6d34ed43068386bcd4a75f828055ee5e Author: Hiltjo Posthuma Date: Thu, 2 Jul 2020 23:26:09 +0200 popen: remove close-on-exec flag to increase portability a bit POSIX says: "If mode is any other value, the result is unspecified.". On atleast older glibc versions (afaik 2008 and older) and on current HaikuOS it seems to not execute popen when "e" is set and set errno to EINVAL.

exit with 128 + signo on receiving SIGHUP, SIGINT, SIGTERM

2020-07-02T21:24:53Z

commit 62d746cb6d34ed43068386bcd4a75f828055ee5e parent f2b48c669ee5b69e3b46f64979739d15f41338c2 Author: Hiltjo Posthuma Date: Thu, 2 Jul 2020 23:24:53 +0200 exit with 128 + signo on receiving SIGHUP, SIGINT, SIGTERM This also makes a better distinction between SIGHUP (=1) and die(), which is also 1.

Use a random temporary directory instead of a fixed one

2020-02-19T20:36:37Z

commit f2b48c669ee5b69e3b46f64979739d15f41338c2 parent 49292644fd4a8c983928738fe36ac9daaebc755d Author: Quentin Rameau Date: Wed, 19 Feb 2020 21:36:37 +0100 Use a random temporary directory instead of a fixed one Thanks to the persons who asked for this.

for displayuri for 'h' types show only the url and not the username field

2020-01-01T17:01:17Z

commit 49292644fd4a8c983928738fe36ac9daaebc755d parent 7f2e86d875364e7828b2af55721e784ca0de5298 Author: Hiltjo Posthuma Date: Wed, 1 Jan 2020 18:01:17 +0100 for displayuri for 'h' types show only the url and not the username field the username is already visible.

Add missing help for next/previous item jump to TI ui.

2019-11-06T16:05:26Z

commit 7f2e86d875364e7828b2af55721e784ca0de5298 parent 88d7f160cb44cdb08634b034b23d2f2d640bf7fd Author: Quentin Rameau Date: Wed, 6 Nov 2019 17:05:26 +0100 Add missing help for next/previous item jump to TI ui. Thanks to William Casarin for spotting this!

remove unused variables

2019-11-02T13:59:59Z

commit 88d7f160cb44cdb08634b034b23d2f2d640bf7fd parent 5b8bd6016a9bc52b643e55335b46de1aaeae2940 Author: Hiltjo Posthuma Date: Sat, 2 Nov 2019 14:59:59 +0100 remove unused variables found by cppcheck

Only block SIGWINCH when connecting

2019-11-02T13:58:47Z

commit 5b8bd6016a9bc52b643e55335b46de1aaeae2940 parent 250ea3842c49c0f1b8224a607e5a4d7fd5dd7ae3 Author: Quentin Rameau Date: Sat, 2 Nov 2019 14:58:47 +0100 Only block SIGWINCH when connecting This relaxes a bit the mask set in dba0b8d.

Fix initial URI search string parsing

2019-10-28T23:24:07Z

commit 250ea3842c49c0f1b8224a607e5a4d7fd5dd7ae3 parent 7bd48fa9930dca90e24e17b78b451b014ae287e8 Author: Quentin Rameau Date: Tue, 29 Oct 2019 00:24:07 +0100 Fix initial URI search string parsing Thanks to Hiltjo for spotting this!

Parse %09 as a search string separator in initial URIs

2019-10-28T23:02:02Z

commit 7bd48fa9930dca90e24e17b78b451b014ae287e8 parent aeb6afa41ddf42eeb865079c7d218a2cbdfe2ef3 Author: Quentin Rameau Date: Tue, 29 Oct 2019 00:02:02 +0100 Parse %09 as a search string separator in initial URIs

Separate search strings with "%09" in URIs, as per RFC

2019-10-28T22:37:31Z

commit aeb6afa41ddf42eeb865079c7d218a2cbdfe2ef3 parent 864e9c534956afb2a429174e10cc9b4d6196fa05 Author: Quentin Rameau Date: Mon, 28 Oct 2019 23:37:31 +0100 Separate search strings with "%09" in URIs, as per RFC

Revert "Fix memory leak in search items"

2019-10-28T11:42:32Z

commit 864e9c534956afb2a429174e10cc9b4d6196fa05 parent 95c60192368eb92fd706aff387aa99df29c8f216 Author: Quentin Rameau Date: Mon, 28 Oct 2019 12:42:32 +0100 Revert "Fix memory leak in search items" This reverts commit 26bc04284d9becc870a6a036a9a6f9bdfba8ba2a. There is actually no leek here as an item without data would not already have a tag.

Add new keybinding for displaying page URI in the manpage

2019-10-28T01:54:38Z

commit 95c60192368eb92fd706aff387aa99df29c8f216 parent 1e11d7ef08cfe5deb5e6adb2845fffd48d5f64d9 Author: Quentin Rameau Date: Mon, 28 Oct 2019 02:54:38 +0100 Add new keybinding for displaying page URI in the manpage

Rephrase txt UI help message

2019-10-28T01:31:26Z

commit 1e11d7ef08cfe5deb5e6adb2845fffd48d5f64d9 parent 3a53a319d4ade0631accac3fd9177e6fbfc49c7f Author: Quentin Rameau Date: Mon, 28 Oct 2019 02:31:26 +0100 Rephrase txt UI help message

Print better URI

2019-10-28T01:12:50Z

commit 3a53a319d4ade0631accac3fd9177e6fbfc49c7f parent 26bc04284d9becc870a6a036a9a6f9bdfba8ba2a Author: Quentin Rameau Date: Mon, 28 Oct 2019 02:12:50 +0100 Print better URI

Fix memory leak in search items

2019-10-28T00:34:11Z

commit 26bc04284d9becc870a6a036a9a6f9bdfba8ba2a parent 0a187a5d95a708254d99a2cdec6bb54b732481a1 Author: Quentin Rameau Date: Mon, 28 Oct 2019 01:34:11 +0100 Fix memory leak in search items

Add a keybinding for displaying current page URI

2019-10-28T00:17:23Z

commit 0a187a5d95a708254d99a2cdec6bb54b732481a1 parent 7ab95c658cf1dd546ec39603851742db65233204 Author: Quentin Rameau Date: Mon, 28 Oct 2019 01:17:23 +0100 Add a keybinding for displaying current page URI

Inverse logic in TI uiselectitem on non-match

2019-10-11T15:17:49Z

commit 7ab95c658cf1dd546ec39603851742db65233204 parent 904cd0f37ae4028597cb85cb08190e998dfac62b Author: Quentin Rameau Date: Fri, 11 Oct 2019 17:17:49 +0200 Inverse logic in TI uiselectitem on non-match

Fix potential uninitialized value in printout

2019-10-11T15:09:31Z

commit 904cd0f37ae4028597cb85cb08190e998dfac62b parent e01ac82824ccd60b4a77498f8e49a443296fcba2 Author: Quentin Rameau Date: Fri, 11 Oct 2019 17:09:31 +0200 Fix potential uninitialized value in printout

Fix potential undefined socket value in connectto

2019-10-11T15:05:57Z

commit e01ac82824ccd60b4a77498f8e49a443296fcba2 parent 827820f5580b8880939337772d85e59ae87721b6 Author: Quentin Rameau Date: Fri, 11 Oct 2019 17:05:57 +0200 Fix potential undefined socket value in connectto

Fix memory leak in downloaditem

2019-10-11T15:02:19Z

commit 827820f5580b8880939337772d85e59ae87721b6 parent 2cc14415ea4515db3271d8af0cc8b36dc62b3f71 Author: Quentin Rameau Date: Fri, 11 Oct 2019 17:02:19 +0200 Fix memory leak in downloaditem Thanks to solene for spotting this!

Fix telnet displayed menu entry

2018-12-28T23:37:34Z

commit 2cc14415ea4515db3271d8af0cc8b36dc62b3f71 parent dba0b8d682e77ac33fbdc6f75dee9ee9f08553f9 Author: Quentin Rameau Date: Sat, 29 Dec 2018 00:37:34 +0100 Fix telnet displayed menu entry

mask signals while using connect(2) in connectto()

2018-12-25T19:44:18Z

commit dba0b8d682e77ac33fbdc6f75dee9ee9f08553f9 parent c7ab5157ebc7e7d502e0970770a7e7be48e61ea2 Author: Hiltjo Posthuma Date: Tue, 25 Dec 2018 20:44:18 +0100 mask signals while using connect(2) in connectto() This makes sure connect(2) don't return a possible < 0 and errno = EINTR. POSIX says for connect(2): " [EINTR] The connection attempt was interrupted by a signal. The attempt will continue asynchronously as if the socket was non-blocking." This was reproducable by launching with st -e sacc bitreich.org . When sacc was signaled with SIGWINCH while it was connecting the connect(2) would be handled as a failure and the next interface was tried. This gave a vague message "no route to host", because the next interfaces could fail.

ui_txt: check for curentry is NULL like ui_ti

2018-12-25T18:33:21Z

commit c7ab5157ebc7e7d502e0970770a7e7be48e61ea2 parent 10ed3e55246b65f39aa19f3c63bb0241c62d4f6c Author: Hiltjo Posthuma Date: Tue, 25 Dec 2018 19:33:21 +0100 ui_txt: check for curentry is NULL like ui_ti This can happen if SIGWINCH is signaled before a connection is made, reproducable with: st -e sacc bitreich.org.

freeaddrinfo can leak if a connection fails in connectto()

2018-12-25T18:32:54Z

commit 10ed3e55246b65f39aa19f3c63bb0241c62d4f6c parent 18a92be39ac2fea50ce2d63c7a03ad64528eb843 Author: Hiltjo Posthuma Date: Tue, 25 Dec 2018 19:32:54 +0100 freeaddrinfo can leak if a connection fails in connectto()

Handle SIGHUP and SIGTERM

2018-11-16T21:24:06Z

commit 18a92be39ac2fea50ce2d63c7a03ad64528eb843 parent ed63d85224f39fc733d55b0d326085d7f4bd0b70 Author: Stefan Hagen Date: Fri, 16 Nov 2018 22:24:06 +0100 Handle SIGHUP and SIGTERM Killing a terminal where sacc is running will send SIGHUP to sacc. With this patch, sacc is handling SIGHUP and SIGTERM and cleans up temporary files properly.

fix undefined behaviours with isdigit() and tolower() functions

2018-09-08T10:44:35Z

commit ed63d85224f39fc733d55b0d326085d7f4bd0b70 parent 2e25654b851d97ab5738a82bd9d47aeb02128be1 Author: Hiltjo Posthuma Date: Sat, 8 Sep 2018 12:44:35 +0200 fix undefined behaviours with isdigit() and tolower() functions

Don't plumb info lines

2018-08-24T22:04:02Z

commit 2e25654b851d97ab5738a82bd9d47aeb02128be1 parent 86b389f19313f0a4479126b36176e52c9e3a610f Author: Stefan Hagen Date: Sat, 25 Aug 2018 00:04:02 +0200 Don't plumb info lines

sacc.1: fix typo

2018-08-24T18:36:26Z

commit 86b389f19313f0a4479126b36176e52c9e3a610f parent 1f25175ac21819a702f38edaf034a16825cd5c07 Author: Hiltjo Posthuma Date: Fri, 24 Aug 2018 20:36:26 +0200 sacc.1: fix typo

Fix regression from 3d2081c, correctly handle '\n' ending lines (bis)

2018-08-24T16:21:44Z

commit 1f25175ac21819a702f38edaf034a16825cd5c07 parent 3399f31a720905a2ebd03191945307b9aafb0ad4 Author: Quentin Rameau Date: Fri, 24 Aug 2018 18:21:44 +0200 Fix regression from 3d2081c, correctly handle '\n' ending lines (bis) This is a followup to 43803be, the patch was not finished.

Handle search (type '7') URIs

2018-08-21T13:12:27Z

commit 3399f31a720905a2ebd03191945307b9aafb0ad4 parent 408fd866df1036c0a51e58a2029dc9c1f41e979c Author: Quentin Rameau Date: Tue, 21 Aug 2018 15:12:27 +0200 Handle search (type '7') URIs

Download non-interactive and unknown types with not term output

2018-08-20T10:02:35Z

commit 408fd866df1036c0a51e58a2029dc9c1f41e979c parent bb8924f35719c580e9fa543a4cbea1258f764acf Author: Quentin Rameau Date: Mon, 20 Aug 2018 12:02:35 +0200 Download non-interactive and unknown types with not term output

Do not use UI functions (uistatus) when output not a term

2018-08-20T09:07:48Z

commit bb8924f35719c580e9fa543a4cbea1258f764acf parent 43803bed9713d10bf08e93ca0a48298be15e9cdf Author: Quentin Rameau Date: Mon, 20 Aug 2018 11:07:48 +0200 Do not use UI functions (uistatus) when output not a term