Subj : feature request
To   : Andrew Leary
From : Janis Kracht
Date : Fri Jul 27 2018 01:25:02

> Hello Michiel!

>Wednesday October 01 2014 18:01, Michiel van der Vlist wrote to Kees van Eeten

>>> Should makenl_ng flag spaces in a node line as errors?

>> Definitely! According to FTS-5000 it IS an error.

> Agreed.

>>> Should makenl_ng remove these spaces,

>> Or replace them with an underscore?

>>> probably a nono, as makenl should not apply automatic editing of
>>> nodelist lines..

>> Replacing with an underscore will most likely give the desired result
>> in the name fields. removing spaces will most likely result in line
>> that parses. Or it may produce another error.

>> Perhaps it is better to let a human judge. But it definitely should be
>> flagged as an error!

>I just dug through the code.  Currently leading or trailing spaces in the firs
> 7 fields (keyword, number, name, location, sysop, telephone, baudrate) of a
> nodelist line will be removed.  The issue here is an incorrect entry with a
>space embedded in the flags field.  MakeNL has never done error checking on th
> flags, which is why ERRFLAGS was developed in the first place.  I suppose I
> could add basic error checking of the flags (probably limited to flagging
> illegal characters such as spaces.)  Anything more extensive would probably
>involve rewriting ERRFLAGS in C and merging it with MakeNL.  That is a project
> that would require extensive amounts of time to code, test, and debug.  Given
>that some of the current ZCs refuse to use ERRFLAGS, I don't imagine they woul
> want to have the equivalent added to MakeNL.

Good points Andrew. I would not like it merged with makenl.

Take care,
Janis

--- BBBS/Li6 v4.10 Dada-1
 * Origin: Prism bbs (1:261/38)

.