Subj : code stench
To   : andrew clarke
From : Rj Clay
Date : Fri Jan 18 2013 15:35:45

andrew,

17 Jan 13 18:47, you wrote to all:

 ac> Unsurprisingly, clang 3.3 is complaining about this bit of code:

 ac> clang -O2 -pipe  -Wall -W -c msgtool.c
 ac> msgtool.c:269:12: warning: cast to 'FILE *' (aka 'struct __sFILE *')
 ac> from smaller integer type 'int' [-Wint-to-pointer-cast]
 ac>     return (FILE *) ! NULL;     /* Just say OK - but it *smells* */
 ac>            ^
 ac> 1 warning generated.

   Haven't seen that one (yet...) under gcc builds, but do see other warnings.


 ac> !NULL is 1. Why would you typecast 1 to FILE *? Baffling.

 ac> No doubt there's a potential segfault lurking in there somewhere...

   Indeed...<g>  Add it to the tracker?



Jame


--- GoldED+/LNX 1.1.5--b20111217
 * Origin: RJC eeePC (1:120/419)

.