Subj : Commit f9ad15e8 might need more work :)
To   : deon
From : Digital Man
Date : Mon Dec 23 2024 14:01:37

  Re: Commit f9ad15e8 might need more work :)
  By: deon to Digital Man on Mon Dec 23 2024 10:30 pm

 >   Re: Commit f9ad15e8 might need more work :)
 >   By: Digital Man to deon on Mon Dec 23 2024 01:05 am
 >
 >  >  > hdr.date = strftime("%a, %d %b %Y %H:%M:%S
 >  >  > %z",this.__properties__.date)
 >
 >  > The 'date' property is specifically for importing from RFC822-formatted
 >  > messages. You probably shouldn't be using that.
 >
 > Isnt strftime("%a, %d %b %Y %H:%M:%S %z") resulting in an RFC822 format?

That's likely correct (for your time zone), but unnecessary (converting to/from string format). Just set when_written_time to a time_t value (e.g. the return value of time() or fdate()).

 > https://validator.w3.org/feed/docs/error/InvalidRFC2822Date.html
 > and https://www.w3.org/Protocols/rfc822/#z28
 >
 > Although the later link says a 2 digit year.

Synchronet will parse 2 or 4+ digit year.

 > What about this format is incorrect (it appeared to result in the correct
 > when_written_time before I updated).

I'm not saying the format is incorrect, I'm saying that you don't need to go through the extra gyrations. That said, you found a bug (lack of conversion to to the new date/bit-field encoding) - now fixed. :-)
-- 
                                            digital man (rob)

Breaking Bad quote #5:
Sometimes the forbidden fruit tastes the sweetest. - Hank Schrader
Norco, CA WX: 68.8øF, 42.0% humidity, 2 mph WSW wind, 0.00 inches rain/24hrs
--- SBBSecho 3.23-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.