electrum, branch HEAD

Add stub for scripthash subscription.

2021-03-12T22:41:29Z

commit bb3b3a559506c359321194f01c10b8e62d8ba448 parent e0a7f86247dbacccaab12fc4159bec6071058b78 Author: parazyd Date: Fri, 12 Mar 2021 23:41:29 +0100 Add stub for scripthash subscription.

interface: Fix gettransaction.

2021-03-12T22:01:19Z

commit e0a7f86247dbacccaab12fc4159bec6071058b78 parent 8c84ffe6af24cf3bf1c08ee67413965ad7c58a1d Author: parazyd Date: Fri, 12 Mar 2021 23:01:19 +0100 interface: Fix gettransaction.

zeromq: Transaction broadcasting.

2021-03-12T21:15:27Z

commit 8c84ffe6af24cf3bf1c08ee67413965ad7c58a1d parent 28ec2b6be35f4d2e8dfdfbc33200ffa31478ecae Author: parazyd Date: Fri, 12 Mar 2021 22:15:27 +0100 zeromq: Transaction broadcasting.

Initial ZeroMQ Interface implementation.

2021-03-12T17:20:26Z

commit 28ec2b6be35f4d2e8dfdfbc33200ffa31478ecae parent 139fc78e196ec76ebc22ec7b50a8e6b84522062b Author: parazyd Date: Fri, 12 Mar 2021 18:20:26 +0100 Initial ZeroMQ Interface implementation. We can now fully sync the headers, and get notified about new headers. Testing with: ./run_electrum --testnet -V i --oneserver The libbitcoin v4 testnet server is hardcoded in the Interface class for now. grep for "TODO: libbitcoin" for further work.

Copy interface.py to old_interface.py.

2021-03-12T17:02:43Z

commit 139fc78e196ec76ebc22ec7b50a8e6b84522062b parent 24e4aa3ab91cd1d7ace8c1996ce86249ed4c7492 Author: parazyd Date: Fri, 12 Mar 2021 18:02:43 +0100 Copy interface.py to old_interface.py.

network.best_effort_reliable: use curio APIs instead of asyncio

2021-03-12T16:53:13Z

commit 24e4aa3ab91cd1d7ace8c1996ce86249ed4c7492 parent 65d263801a7e419c953db38eb084deb3ea959ef1 Author: SomberNight Date: Fri, 12 Mar 2021 17:53:13 +0100 network.best_effort_reliable: use curio APIs instead of asyncio

show capacity of channel backups in GUI

2021-03-12T16:38:42Z

commit 65d263801a7e419c953db38eb084deb3ea959ef1 parent 3ff203ea51a87ad0ca55a91764210ca3e02b471c Author: ThomasV Date: Fri, 12 Mar 2021 17:38:42 +0100 show capacity of channel backups in GUI

commands: fix list_requests

2021-03-12T16:38:19Z

commit 3ff203ea51a87ad0ca55a91764210ca3e02b471c parent 897f90d6e88b694c1bde990a5abce85ccb8e8c96 Author: SomberNight Date: Fri, 12 Mar 2021 17:38:19 +0100 commands: fix list_requests closes https://github.com/spesmilo/electrum/issues/7102

wallet: factor out "what key to use for invoice"

2021-03-12T16:29:54Z

commit 897f90d6e88b694c1bde990a5abce85ccb8e8c96 parent 1a4e55a911f9c6783d5840c781f36e246c186efe Author: SomberNight Date: Fri, 12 Mar 2021 17:29:54 +0100 wallet: factor out "what key to use for invoice" fix: qt request list was not using the correct key

follow-up 90b228de839d6474f6d23322cd2a80e1da73a254

2021-03-12T15:38:48Z

commit 1a4e55a911f9c6783d5840c781f36e246c186efe parent 8984db338404c1f4a9d8165ecced02139051b432 Author: ThomasV Date: Fri, 12 Mar 2021 16:38:48 +0100 follow-up 90b228de839d6474f6d23322cd2a80e1da73a254

follow-up 90b228de839d6474f6d23322cd2a80e1da73a254

2021-03-12T15:28:42Z

commit 8984db338404c1f4a9d8165ecced02139051b432 parent af7bcd4ca1ef81eeb8663c5289c9059d330f298a Author: ThomasV Date: Fri, 12 Mar 2021 16:28:42 +0100 follow-up 90b228de839d6474f6d23322cd2a80e1da73a254

add comments about ChannelBackup fields

2021-03-12T15:11:47Z

commit af7bcd4ca1ef81eeb8663c5289c9059d330f298a parent f16358ec3c60cef07c63257a64315f53e044acb7 Author: ThomasV Date: Fri, 12 Mar 2021 16:11:47 +0100 add comments about ChannelBackup fields

add request_force_close command to CLI add regtest for channel backup

2021-03-12T15:10:02Z

commit f16358ec3c60cef07c63257a64315f53e044acb7 parent bed4ddbcb4f9d2efa8334ebae21550577f83a2eb Author: ThomasV Date: Fri, 12 Mar 2021 16:10:02 +0100 add request_force_close command to CLI add regtest for channel backup

fix dict value assignment bug in import_channel_backup. In request_force_close, use Taskgroup with wait=any

2021-03-12T15:09:24Z

commit bed4ddbcb4f9d2efa8334ebae21550577f83a2eb parent e186214f6f2d0612fe1d4df974c4c85ba07f182c Author: ThomasV Date: Fri, 12 Mar 2021 16:09:24 +0100 fix dict value assignment bug in import_channel_backup. In request_force_close, use Taskgroup with wait=any

(formatting) lnsweep indentation

2021-03-12T11:41:10Z

commit e186214f6f2d0612fe1d4df974c4c85ba07f182c parent 90b228de839d6474f6d23322cd2a80e1da73a254 Author: ThomasV Date: Fri, 12 Mar 2021 12:41:10 +0100 (formatting) lnsweep indentation

fix wallet get_full_history: add onchain tx for channels not opened by us

2021-03-12T10:40:53Z

commit 90b228de839d6474f6d23322cd2a80e1da73a254 parent 6004a047053e97b9f613d8329f690d1fd6d920fb Author: ThomasV Date: Fri, 12 Mar 2021 11:40:53 +0100 fix wallet get_full_history: add onchain tx for channels not opened by us

Merge pull request #7099 from SomberNight/202103_fail_pending_htlcs_on_shutdown

2021-03-12T10:01:07Z

commit 6004a047053e97b9f613d8329f690d1fd6d920fb parent 05e58671c92940620aab36cf5946a0f1dd24c013 Author: ThomasV Date: Fri, 12 Mar 2021 11:01:07 +0100 Merge pull request #7099 from SomberNight/202103_fail_pending_htlcs_on_shutdown fail pending htlcs on shutdown

lnhtlc: (trivial) rename method

2021-03-11T18:09:35Z

commit 05e58671c92940620aab36cf5946a0f1dd24c013 parent 54f7755397f5c4a4ce3215ddad70f342f06cf9fe Author: SomberNight Date: Thu, 11 Mar 2021 19:09:35 +0100 lnhtlc: (trivial) rename method

lnpeer.maybe_forward_htlc: add FIXME

2021-03-11T17:51:45Z

commit 54f7755397f5c4a4ce3215ddad70f342f06cf9fe parent 28a7d204ad6e8bfa503f9f8afe2b8f23cb16238e Author: SomberNight Date: Thu, 11 Mar 2021 18:51:45 +0100 lnpeer.maybe_forward_htlc: add FIXME

util: document CallbackManager behaviour

2021-03-11T17:50:59Z

commit 28a7d204ad6e8bfa503f9f8afe2b8f23cb16238e parent 533d796a4149cac7038ae5503e6c089de60ba614 Author: SomberNight Date: Thu, 11 Mar 2021 18:50:59 +0100 util: document CallbackManager behaviour

add TODO, rename check_received_mpp_htlc

2021-03-11T15:53:55Z

commit 533d796a4149cac7038ae5503e6c089de60ba614 parent 10c799faab45ea53962d89527bf72bdc392c9862 Author: ThomasV Date: Thu, 11 Mar 2021 16:53:55 +0100 add TODO, rename check_received_mpp_htlc

mpp_split: add penalty for exhaustion of channels

2021-03-11T11:00:47Z

commit 10c799faab45ea53962d89527bf72bdc392c9862 parent 1b7d8c0387734463dca66ddc978b4c966320272d Author: bitromortac Date: Thu, 11 Mar 2021 12:00:47 +0100 mpp_split: add penalty for exhaustion of channels A penalty is added for split configurations which saturate a channel. Saturation of channels is discouraged as we don't know the fees beforehand. The penalty is accomplished via an exponential function that kicks in when the subamount reaches about the total funds available (this amount is controlled by the parameter EXHAUST_DECAY_FRACTION).

Qt: rm gossip menu item: already available in toolbar, and channel_db is not always present

2021-03-11T13:44:13Z

commit 1b7d8c0387734463dca66ddc978b4c966320272d parent dc55cf4b2d23d84bcde26448c85f0842d611063e Author: ThomasV Date: Thu, 11 Mar 2021 14:44:13 +0100 Qt: rm gossip menu item: already available in toolbar, and channel_db is not always present

test_multipart_payment_with_timeout: give extra time for second HTLC to timeout before next test

2021-03-11T10:01:35Z

commit dc55cf4b2d23d84bcde26448c85f0842d611063e parent 50ab8be7a29d1b1ece777d611a2a77e49402c689 Author: ThomasV Date: Thu, 11 Mar 2021 11:01:35 +0100 test_multipart_payment_with_timeout: give extra time for second HTLC to timeout before next test

lnpeer: try to fix tests

2021-03-11T09:37:44Z

commit 50ab8be7a29d1b1ece777d611a2a77e49402c689 parent 707a58abf11c541ca5e8b69d092d612d7613c538 Author: ThomasV Date: Thu, 11 Mar 2021 10:37:44 +0100 lnpeer: try to fix tests

crypto: add comment about ripemd.py

2021-03-10T20:28:17Z

commit 707a58abf11c541ca5e8b69d092d612d7613c538 parent a7c948bac124a916f530be6c4055061ff72c29a0 Author: SomberNight Date: Wed, 10 Mar 2021 21:28:17 +0100 crypto: add comment about ripemd.py related: https://github.com/spesmilo/electrum/issues/7093

tests: fix tearDown() issue in test_lnrouter.py

2021-03-10T20:23:41Z

commit a7c948bac124a916f530be6c4055061ff72c29a0 parent 4250f3b8a19f1f56a5eba21b1c3d33e9f2b17924 Author: SomberNight Date: Wed, 10 Mar 2021 21:23:41 +0100 tests: fix tearDown() issue in test_lnrouter.py similar to 05fd42454842bdce853e96d6b3ffbb043960f7c4 from logs when running tests: --- Logging error --- Traceback (most recent call last): File "...\Python39\lib\logging\__init__.py", line 1082, in emit stream.write(msg + self.terminator) ValueError: I/O operation on closed file. Call stack: File "...\Python39\lib\threading.py", line 912, in _bootstrap self._bootstrap_inner() File "...\Python39\lib\threading.py", line 954, in _bootstrap_inner self.run() File "...\Python39\lib\threading.py", line 892, in run self._target(*self._args, **self._kwargs) File "...\electrum\electrum\sql_db.py", line 71, in run_sql self.logger.info("SQL thread terminated") Message: 'SQL thread terminated' Arguments: ()

test_lnpeer: use 2s MPP_TIMEOUT, and split test_multipart_payment_with_timeout

2021-03-10T20:00:58Z

commit 4250f3b8a19f1f56a5eba21b1c3d33e9f2b17924 parent 05fd42454842bdce853e96d6b3ffbb043960f7c4 Author: ThomasV Date: Wed, 10 Mar 2021 21:00:58 +0100 test_lnpeer: use 2s MPP_TIMEOUT, and split test_multipart_payment_with_timeout

tests: maybe fix tearDown() issue in test_storage_upgrade.py

2021-03-10T19:16:25Z

commit 05fd42454842bdce853e96d6b3ffbb043960f7c4 parent 5339e0054c6e473ec4b5858ea9bb11aeb37be109 Author: SomberNight Date: Wed, 10 Mar 2021 20:16:25 +0100 tests: maybe fix tearDown() issue in test_storage_upgrade.py from travis logs: --- Logging error --- Traceback (most recent call last): File "/opt/python/3.7.6/lib/python3.7/logging/__init__.py", line 1028, in emit stream.write(msg + self.terminator) ValueError: I/O operation on closed file. Call stack: File "/opt/python/3.7.6/lib/python3.7/threading.py", line 890, in _bootstrap self._bootstrap_inner() File "/opt/python/3.7.6/lib/python3.7/threading.py", line 926, in _bootstrap_inner self.run() File "/home/travis/build/spesmilo/electrum/electrum/plugin.py", line 213, in run self.run_jobs() File "/home/travis/build/spesmilo/electrum/electrum/util.py", line 359, in on_stop self.logger.info("stopped") Message: 'stopped'

network.stop: clean-up

2021-03-10T18:01:30Z

commit 5339e0054c6e473ec4b5858ea9bb11aeb37be109 parent de6f5a8e0357b201b5f0ffe20195b36cad66824d Author: SomberNight Date: Wed, 10 Mar 2021 19:01:30 +0100 network.stop: clean-up

{daemon,wallet}|.stop: small clean-up

2021-03-10T17:07:15Z

commit de6f5a8e0357b201b5f0ffe20195b36cad66824d parent eaa4de33541a56af049b8d48b92f206ed47f785a Author: SomberNight Date: Wed, 10 Mar 2021 18:07:15 +0100 {daemon,wallet}|.stop: small clean-up

kivy crash_reporter: a bit more logging

2021-03-10T16:38:53Z

commit eaa4de33541a56af049b8d48b92f206ed47f785a parent 151a45911f028b1b466e001a0fd8fad467d60bf1 Author: SomberNight Date: Wed, 10 Mar 2021 17:38:53 +0100 kivy crash_reporter: a bit more logging

follow-up prev: too much copy-paste

2021-03-10T16:31:02Z

commit 151a45911f028b1b466e001a0fd8fad467d60bf1 parent 9740744d70461d9b0f02a78f836784bc91ff2d1a Author: SomberNight Date: Wed, 10 Mar 2021 17:31:02 +0100 follow-up prev: too much copy-paste

crypto: add chacha20_decrypt; unused for now

2021-03-10T16:13:42Z

commit 9740744d70461d9b0f02a78f836784bc91ff2d1a parent 549b9a95df6fedbf0880df139a99f419931150e1 Author: SomberNight Date: Wed, 10 Mar 2021 17:13:42 +0100 crypto: add chacha20_decrypt; unused for now

test_lnpeer: add test for mpp_timeout

2021-03-10T16:09:07Z

commit 549b9a95df6fedbf0880df139a99f419931150e1 parent d4de25a8cde35ee47a7594194eef794a1b4f7b2b Author: ThomasV Date: Wed, 10 Mar 2021 17:09:07 +0100 test_lnpeer: add test for mpp_timeout

crash reports: fix get_git_version for kivy

2021-03-10T15:23:49Z

commit d4de25a8cde35ee47a7594194eef794a1b4f7b2b parent 6620974f3deea4e3d3f42a63eccd30192e41b89c Author: SomberNight Date: Wed, 10 Mar 2021 16:23:49 +0100 crash reports: fix get_git_version for kivy

follow-up 652d10aa5f810d6db00ce4870ea7c779f9ff35a4

2021-03-10T14:26:39Z

commit 6620974f3deea4e3d3f42a63eccd30192e41b89c parent 0e01db4cee6c2438ae17ccc450e901101c6aa2bf Author: ThomasV Date: Wed, 10 Mar 2021 15:26:39 +0100 follow-up 652d10aa5f810d6db00ce4870ea7c779f9ff35a4

kivy: fix GridLayout orientations all over

2021-03-10T13:59:47Z

commit 0e01db4cee6c2438ae17ccc450e901101c6aa2bf parent 7ae82c82300c0a08e1a5ba023c439566aba6109f Author: SomberNight Date: Wed, 10 Mar 2021 14:59:47 +0100 kivy: fix GridLayout orientations all over Pre kivy 2.0, "orientation" was undefined for GridLayouts, not sure why we were setting it, it was a no-op. kivy 2.0 added meaning to the field, and the values we were setting it to are invalid. related: https://github.com/kivy/kivy/pull/6741 https://github.com/kivy/kivy/issues/7142 ----- traceback: E | gui.kivy.uix.dialogs.crash_reporter.ExceptionHook | exception caught by crash reporter Traceback (most recent call last): File "/home/user/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 705, in _apply_rule setattr(widget_set, key, value) File "kivy/weakproxy.pyx", line 35, in kivy.weakproxy.WeakProxy.__setattr__ File "kivy/properties.pyx", line 498, in kivy.properties.Property.__set__ File "kivy/properties.pyx", line 542, in kivy.properties.Property.set File "kivy/properties.pyx", line 533, in kivy.properties.Property.set File "kivy/properties.pyx", line 1253, in kivy.properties.OptionProperty.check ValueError: GridLayout.orientation is set to an invalid option 'vertical'. Must be one of: ['lr-tb', 'tb-lr', 'rl-tb', 'tb-rl', 'lr-bt', 'bt-lr', 'rl-bt', 'bt-rl'] During handling of the above exception, another exception occurred: Traceback (most recent call last): File "kivy/_clock.pyx", line 645, in kivy._clock.CyClockBase._process_events File "kivy/_clock.pyx", line 218, in kivy._clock.ClockEvent.tick File "/home/user/wspace/electrum/electrum/gui/kivy/uix/ui_screens/receive.kv", line 141, in on_release: Clock.schedule_once(lambda dt: s.expiration_dialog(s)) File "/home/user/wspace/electrum/electrum/gui/kivy/uix/screens.py", line 517, in expiration_dialog d = ChoiceDialog(_('Expiration date'), pr_expiration_values, self.expiry(), callback) File "/home/user/wspace/electrum/electrum/gui/kivy/uix/dialogs/choice_dialog.py", line 53, in __init__ Factory.Popup.__init__(self) File "/home/user/.local/lib/python3.8/site-packages/kivy/uix/modalview.py", line 187, in __init__ super(ModalView, self).__init__(**kwargs) File "/home/user/.local/lib/python3.8/site-packages/kivy/uix/anchorlayout.py", line 68, in __init__ super(AnchorLayout, self).__init__(**kwargs) File "/home/user/.local/lib/python3.8/site-packages/kivy/uix/layout.py", line 76, in __init__ super(Layout, self).__init__(**kwargs) File "/home/user/.local/lib/python3.8/site-packages/kivy/uix/widget.py", line 359, in __init__ self.apply_class_lang_rules( File "/home/user/.local/lib/python3.8/site-packages/kivy/uix/widget.py", line 463, in apply_class_lang_rules Builder.apply( File "/home/user/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 541, in apply self._apply_rule( File "/home/user/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 710, in _apply_rule raise BuilderException(rule.ctx, rule.line, kivy.lang.builder.BuilderException: Parser: File "", line 21: ... 19: GridLayout: 20: row_default_height: '48dp' >> 21: orientation: 'vertical' 22: id: choices 23: cols: 2 ... ValueError: GridLayout.orientation is set to an invalid option 'vertical'. Must be one of: ['lr-tb', 'tb-lr', 'rl-tb', 'tb-rl', 'lr-bt', 'bt-lr', 'rl-bt', 'bt-rl'] File "/home/user/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 705, in _apply_rule setattr(widget_set, key, value) File "kivy/weakproxy.pyx", line 35, in kivy.weakproxy.WeakProxy.__setattr__ File "kivy/properties.pyx", line 498, in kivy.properties.Property.__set__ File "kivy/properties.pyx", line 542, in kivy.properties.Property.set File "kivy/properties.pyx", line 533, in kivy.properties.Property.set File "kivy/properties.pyx", line 1253, in kivy.properties.OptionProperty.check

Revert "lnworker: simplify request_force_close_from_backup"

2021-03-10T11:54:00Z

commit 7ae82c82300c0a08e1a5ba023c439566aba6109f parent abc155b6887afea4cc082328f86a09c668523214 Author: ThomasV Date: Wed, 10 Mar 2021 12:54:00 +0100 Revert "lnworker: simplify request_force_close_from_backup" This reverts commit ce88b36e81a533810b08ccf8796120951265da8a.

Appimage build: update git=1:2.7.4-0ubuntu1.10 15b5d9d (#7091)

2021-03-09T23:35:02Z

commit abc155b6887afea4cc082328f86a09c668523214 parent 8de52bf523bff8280de02e8015d31ccd525f3c0e Author: gruve-p Date: Wed, 10 Mar 2021 00:35:02 +0100 Appimage build: update git=1:2.7.4-0ubuntu1.10 15b5d9d (#7091)

wallet: (trivial) use kwargs for get_tx_item_fiat

2021-03-09T17:22:30Z

commit 8de52bf523bff8280de02e8015d31ccd525f3c0e parent 3c019c2f9c4d2fdefe52d84444632b54d421e140 Author: SomberNight Date: Tue, 9 Mar 2021 18:22:30 +0100 wallet: (trivial) use kwargs for get_tx_item_fiat

daemon/wallet/network: make stop() methods async

2021-03-09T16:52:36Z

commit 3c019c2f9c4d2fdefe52d84444632b54d421e140 parent ce88b36e81a533810b08ccf8796120951265da8a Author: SomberNight Date: Tue, 9 Mar 2021 17:52:36 +0100 daemon/wallet/network: make stop() methods async

lnworker: simplify request_force_close_from_backup

2021-03-09T11:28:25Z

commit ce88b36e81a533810b08ccf8796120951265da8a parent 652d10aa5f810d6db00ce4870ea7c779f9ff35a4 Author: ThomasV Date: Tue, 9 Mar 2021 12:28:25 +0100 lnworker: simplify request_force_close_from_backup

Remove LNBackups object: no longer needed since LNWorker is instantiated by default.

2021-03-09T08:55:55Z

commit 652d10aa5f810d6db00ce4870ea7c779f9ff35a4 parent ef661050c8da36b7b2b73bec47dbaeddb38301f5 Author: ThomasV Date: Tue, 9 Mar 2021 09:55:55 +0100 Remove LNBackups object: no longer needed since LNWorker is instantiated by default.

lnworker: set request status after LN payment

2021-03-09T08:35:43Z

commit ef661050c8da36b7b2b73bec47dbaeddb38301f5 parent a125cd5392d8aa873b15663e59b5d3c269977afc Author: ThomasV Date: Tue, 9 Mar 2021 09:35:43 +0100 lnworker: set request status after LN payment

tests: test payreq status after getting paid via LN

2021-03-08T21:18:06Z

commit a125cd5392d8aa873b15663e59b5d3c269977afc parent f662859e5c7745eccaa7af195c9915035e38eb94 Author: SomberNight Date: Mon, 8 Mar 2021 22:18:06 +0100 tests: test payreq status after getting paid via LN The test failures corresponding to single-part (non-MPP) payments expose a bug. see https://github.com/spesmilo/electrum/blob/196b4c00a35b288f28885c0ceb8afdd5ffbd9a0f/electrum/lnpeer.py#L1538-L1539 `lnworker.add_received_htlc` is not called for single-part payments...

test_lnpeer: (trivial) prepare_invoice to return both LnAddr and str

2021-03-08T20:46:56Z

commit f662859e5c7745eccaa7af195c9915035e38eb94 parent 4069b455d0059dd3ba26adbad5389255fcac84f0 Author: SomberNight Date: Mon, 8 Mar 2021 21:46:56 +0100 test_lnpeer: (trivial) prepare_invoice to return both LnAddr and str

lnaddr: add get_features method

2021-03-08T20:36:27Z

commit 4069b455d0059dd3ba26adbad5389255fcac84f0 parent 196b4c00a35b288f28885c0ceb8afdd5ffbd9a0f Author: SomberNight Date: Mon, 8 Mar 2021 21:36:27 +0100 lnaddr: add get_features method

Use new value of option_trampoline_routing flag, add it to our invoices. Keep supporting old value for Eclair/Phoenix. Do not add trampoline_routing_hints in invoices.

2021-03-08T17:49:52Z

commit 196b4c00a35b288f28885c0ceb8afdd5ffbd9a0f parent 0491da2c662fdf74c1470acdb2bb856640780245 Author: ThomasV Date: Mon, 8 Mar 2021 18:49:52 +0100 Use new value of option_trampoline_routing flag, add it to our invoices. Keep supporting old value for Eclair/Phoenix. Do not add trampoline_routing_hints in invoices.

lnpeer: (trivial) log htlc in on_update_add_htlc

2021-03-08T17:51:52Z

commit 0491da2c662fdf74c1470acdb2bb856640780245 parent fd48b96335b6466ebaf270b2cc3c734e200e30d1 Author: SomberNight Date: Mon, 8 Mar 2021 18:51:52 +0100 lnpeer: (trivial) log htlc in on_update_add_htlc

follow-up prev commit

2021-03-08T16:45:00Z

commit fd48b96335b6466ebaf270b2cc3c734e200e30d1 parent 308b02ca7dc2427583a32784f6bde4dec08d1069 Author: ThomasV Date: Mon, 8 Mar 2021 17:45:00 +0100 follow-up prev commit

lnworker: fix amount in htlc_log after mpp bucket failure

2021-03-08T16:23:52Z

commit 308b02ca7dc2427583a32784f6bde4dec08d1069 parent 5df4466812b011b2d16e0be0aac5c56631ac712b Author: ThomasV Date: Mon, 8 Mar 2021 17:23:52 +0100 lnworker: fix amount in htlc_log after mpp bucket failure

rm fixme; it was for intermediate stage, between commits.

2021-03-08T12:30:51Z

commit 5df4466812b011b2d16e0be0aac5c56631ac712b parent cf5bf5d1afbd785b24e90b2457d4f7cc82c902df Author: ThomasV Date: Mon, 8 Mar 2021 13:30:51 +0100 rm fixme; it was for intermediate stage, between commits.

windows build: skip building pyinstaller if already there

2021-03-08T02:03:31Z

commit cf5bf5d1afbd785b24e90b2457d4f7cc82c902df parent 41233a4bc72d5551a197b02167a0fd0cf98fe50f Author: SomberNight Date: Mon, 8 Mar 2021 03:03:31 +0100 windows build: skip building pyinstaller if already there

windows build: minor clean-up

2021-03-07T21:58:44Z

commit 41233a4bc72d5551a197b02167a0fd0cf98fe50f parent dded25f39874223b0d5d6c94ca9824542f4f4584 Author: SomberNight Date: Sun, 7 Mar 2021 22:58:44 +0100 windows build: minor clean-up

windows build: cache pip downloads

2021-03-07T21:12:26Z

commit dded25f39874223b0d5d6c94ca9824542f4f4584 parent f1f584c4c43586a265f11291da0ddbb4ab1a2f79 Author: SomberNight Date: Sun, 7 Mar 2021 22:12:26 +0100 windows build: cache pip downloads

windows build: separate 32/64 bit build caches

2021-03-07T13:28:16Z

commit f1f584c4c43586a265f11291da0ddbb4ab1a2f79 parent e07f615bbbddfa28181ca8ede15c403210d7c702 Author: SomberNight Date: Sun, 7 Mar 2021 14:28:16 +0100 windows build: separate 32/64 bit build caches specify which architecture to target by setting WIN_ARCH env var

windows binaries: update pyinstaller to 4.2

2021-03-07T15:21:42Z

commit e07f615bbbddfa28181ca8ede15c403210d7c702 parent 7698ab4ccb11451a1964ac03e00e258f431c2a41 Author: SomberNight Date: Sun, 7 Mar 2021 16:21:42 +0100 windows binaries: update pyinstaller to 4.2

android build: update kivy, and python

2021-03-06T13:42:01Z

commit 7698ab4ccb11451a1964ac03e00e258f431c2a41 parent edb214aeca91de2d0f3719c0258e98592bef6481 Author: SomberNight Date: Sat, 6 Mar 2021 14:42:01 +0100 android build: update kivy, and python

lnworker.pay_to_node: re overpayment, raise before actually it happens

2021-03-06T13:23:00Z

commit edb214aeca91de2d0f3719c0258e98592bef6481 parent 6ddd02506eefcbef358c18bcb5fb8106400a3c2b Author: SomberNight Date: Sat, 6 Mar 2021 14:23:00 +0100 lnworker.pay_to_node: re overpayment, raise before actually it happens

test_lnpeer: add missing parameter in pay_to_route

2021-03-06T09:59:29Z

commit 6ddd02506eefcbef358c18bcb5fb8106400a3c2b parent 83993768e5309c504ae6c419d40986d5e374b9d2 Author: ThomasV Date: Sat, 6 Mar 2021 10:59:29 +0100 test_lnpeer: add missing parameter in pay_to_route

trampoline: do not add node in trampoline hints if it already is the last trampoline of the route

2021-03-05T23:26:55Z

commit 83993768e5309c504ae6c419d40986d5e374b9d2 parent 5663e598637d5cf8aba6b2be8c2b3ccc609fd692 Author: ThomasV Date: Sat, 6 Mar 2021 00:26:55 +0100 trampoline: do not add node in trampoline hints if it already is the last trampoline of the route

lnworker: fix amount_inflight. (amount with routing fees were used on htlc failures)

2021-03-06T09:45:52Z

commit 5663e598637d5cf8aba6b2be8c2b3ccc609fd692 parent d3d476f44c57cc9c545f9dabddf32897b84c784c Author: ThomasV Date: Sat, 6 Mar 2021 10:45:52 +0100 lnworker: fix amount_inflight. (amount with routing fees were used on htlc failures)

lnpeer: fix error code in logs

2021-03-05T23:31:30Z

commit d3d476f44c57cc9c545f9dabddf32897b84c784c parent 31919d0425b1f5828d202f1bfb095eb8c5dfcff2 Author: ThomasV Date: Sat, 6 Mar 2021 00:31:30 +0100 lnpeer: fix error code in logs

lnworker: add assert amount_inflight <= amount_to_pay

2021-03-05T23:29:37Z

commit 31919d0425b1f5828d202f1bfb095eb8c5dfcff2 parent 529e96aaf9a90be5c7d48db704c43eaeb751263b Author: ThomasV Date: Sat, 6 Mar 2021 00:29:37 +0100 lnworker: add assert amount_inflight <= amount_to_pay

synchronizer: (trivial) add comment

2021-03-05T20:04:20Z

commit 529e96aaf9a90be5c7d48db704c43eaeb751263b parent 1dbff51fce762c212913c2c446d6e5945f283f75 Author: SomberNight Date: Fri, 5 Mar 2021 21:04:20 +0100 synchronizer: (trivial) add comment

synchronizer: fix rare race where synchronizer could get stuck

2021-03-05T19:46:41Z

commit 1dbff51fce762c212913c2c446d6e5945f283f75 parent 34413a9c306a297c833ed2b5e267e61ca297a225 Author: SomberNight Date: Fri, 5 Mar 2021 20:46:41 +0100 synchronizer: fix rare race where synchronizer could get stuck

python 3.6 compat: asyncio.Task.set_name was added in 3.8

2021-03-05T19:11:54Z

commit 34413a9c306a297c833ed2b5e267e61ca297a225 parent 5207c40cc3ef782765e2a413248025d42c156edc Author: SomberNight Date: Fri, 5 Mar 2021 20:11:54 +0100 python 3.6 compat: asyncio.Task.set_name was added in 3.8

fix trampoline forwarding: add_received_htlc must be indexed by payment_secret

2021-03-05T16:02:10Z

commit 5207c40cc3ef782765e2a413248025d42c156edc parent 59547d05138b0e90413ac4f60f81d5af8564516b Author: ThomasV Date: Fri, 5 Mar 2021 17:02:10 +0100 fix trampoline forwarding: add_received_htlc must be indexed by payment_secret

test_lnpeer: variables must be declared in MockLNWallet.init

2021-03-05T16:04:06Z

commit 59547d05138b0e90413ac4f60f81d5af8564516b parent 762ebb12b253dd53517dbd99b13efcc0e0168b05 Author: ThomasV Date: Fri, 5 Mar 2021 17:04:06 +0100 test_lnpeer: variables must be declared in MockLNWallet.__init__

lnpeer: increase max_accepted_htlcs (5->30)

2021-03-05T15:12:01Z

commit 762ebb12b253dd53517dbd99b13efcc0e0168b05 parent f397b315ac437d47e1583d3320c5c5058ba820f7 Author: SomberNight Date: Fri, 5 Mar 2021 16:12:01 +0100 lnpeer: increase max_accepted_htlcs (5->30) Counter-intuitively, the motivation is to be able to *send* more htlcs, for MPP trickery. We don't offer more htlcs than this limit, to be conservative with what we send, and to interoperate with clightning. defaults of other clients: eclair: 30 clightning: 30 lnd: 483

remove trampoline and forwarding regtests, as they are covered by unittests

2021-03-05T12:18:44Z

commit f397b315ac437d47e1583d3320c5c5058ba820f7 parent 1f60d5d8eee3a908ae22f58c29391ef0bab87c64 Author: ThomasV Date: Fri, 5 Mar 2021 13:18:44 +0100 remove trampoline and forwarding regtests, as they are covered by unittests

test_lnpeer: add test for trampoline

2021-03-05T12:00:24Z

commit 1f60d5d8eee3a908ae22f58c29391ef0bab87c64 parent eda9097e894b4e94b17160701cf242ad8da76635 Author: ThomasV Date: Fri, 5 Mar 2021 13:00:24 +0100 test_lnpeer: add test for trampoline

trampoline forwarding: return UNKNOWN_NEXT_PEER if we cannot find a route

2021-03-05T11:47:18Z

commit eda9097e894b4e94b17160701cf242ad8da76635 parent 6cc3480356ff61e5687b20fde0a3d8d3616f7295 Author: ThomasV Date: Fri, 5 Mar 2021 12:47:18 +0100 trampoline forwarding: return UNKNOWN_NEXT_PEER if we cannot find a route

follow-up prev commit

2021-03-05T09:23:00Z

commit 6cc3480356ff61e5687b20fde0a3d8d3616f7295 parent 16554afa1b62c0ea5d759add7bdb640a0a059f95 Author: ThomasV Date: Fri, 5 Mar 2021 10:23:00 +0100 follow-up prev commit

follow-up previous commit (this was for testing)

2021-03-05T09:14:26Z

commit 16554afa1b62c0ea5d759add7bdb640a0a059f95 parent 2e4f45ec7446f43e2861cc971bf70ed189590bac Author: ThomasV Date: Fri, 5 Mar 2021 10:14:26 +0100 follow-up previous commit (this was for testing)

use two trampolines: fix blacklisting, use local variables for trampoline_fee_level and use_two_trampolines

2021-03-05T09:07:02Z

commit 2e4f45ec7446f43e2861cc971bf70ed189590bac parent ec6baa12f81065ee5b110d6c277a24d752acb11d Author: ThomasV Date: Fri, 5 Mar 2021 10:07:02 +0100 use two trampolines: fix blacklisting, use local variables for trampoline_fee_level and use_two_trampolines

follow-up prev

2021-03-04T16:50:52Z

commit ec6baa12f81065ee5b110d6c277a24d752acb11d parent 064670bd75a67cb41ce42e03ea24f4583e9d1725 Author: SomberNight Date: Thu, 4 Mar 2021 17:50:52 +0100 follow-up prev oops, that was just for local testing

network: close interfaces more aggressively (abort after 2 seconds)

2021-03-04T16:47:49Z

commit 064670bd75a67cb41ce42e03ea24f4583e9d1725 parent ff485cee62d33c5f6f95a425839026fa8872cd02 Author: SomberNight Date: Thu, 4 Mar 2021 17:47:49 +0100 network: close interfaces more aggressively (abort after 2 seconds) fixes #7083

use functools.wraps() for some wrappers

2021-03-04T15:44:13Z

commit ff485cee62d33c5f6f95a425839026fa8872cd02 parent 859f8ccf8e5c784d9c2e307f5ff4f8cc293ee27d Author: SomberNight Date: Thu, 4 Mar 2021 16:44:13 +0100 use functools.wraps() for some wrappers to help debugging

fix wallet.clear_history()

2021-03-04T13:25:41Z

commit 859f8ccf8e5c784d9c2e307f5ff4f8cc293ee27d parent 5a2a724cb998bf414f3d3213138ac5385c64aaa0 Author: SomberNight Date: Thu, 4 Mar 2021 14:25:41 +0100 fix wallet.clear_history() it would result in "wallet.get_history() failed balance sanity-check" maybe related: https://github.com/spesmilo/electrum/issues/6792

Receive MPP: Use persisted payment status to decide whether to fulfill HTLCs. Without this commit, we might timeout a part of a payment if the client is shut down before all parts are fulfilled.

2021-03-04T13:08:31Z

commit 5a2a724cb998bf414f3d3213138ac5385c64aaa0 parent e25602ab3be4c43f883d427cdad1d3071b010437 Author: ThomasV Date: Thu, 4 Mar 2021 14:08:31 +0100 Receive MPP: Use persisted payment status to decide whether to fulfill HTLCs. Without this commit, we might timeout a part of a payment if the client is shut down before all parts are fulfilled.

wallet: don't put partial tx as UTXO into psbt

2021-03-04T12:20:49Z

commit e25602ab3be4c43f883d427cdad1d3071b010437 parent 785fe6aeeacef8b88cb2b8adb19df6d1612b9a1a Author: SomberNight Date: Thu, 4 Mar 2021 13:20:49 +0100 wallet: don't put partial tx as UTXO into psbt if there is a chain of unsigned txs, we cannot populate NON_WITNESS_UTXO closes #7080 closes #7009 closes #6482

lnutil: (trivial) add ShortChannelID.from_str() method

2021-03-04T11:14:47Z

commit 785fe6aeeacef8b88cb2b8adb19df6d1612b9a1a parent 738411e32bacbb6d2859cbbc782634e3d5dff7d2 Author: SomberNight Date: Thu, 4 Mar 2021 12:14:47 +0100 lnutil: (trivial) add ShortChannelID.from_str() method for console use atm

Trampoline forwarding: - fix regression in create_routes: fwd_trampoline_onion was not added to the tuple - fix onion structure for e2e - maybe_fulfill_htlc: check the mpp_status of the outer onion, return trampoline_onion to be forwarded

2021-03-03T19:36:48Z

commit 738411e32bacbb6d2859cbbc782634e3d5dff7d2 parent ba4d6bc8b34d17a998c011276ef57aab7f0c5106 Author: ThomasV Date: Wed, 3 Mar 2021 20:36:48 +0100 Trampoline forwarding: - fix regression in create_routes: fwd_trampoline_onion was not added to the tuple - fix onion structure for e2e - maybe_fulfill_htlc: check the mpp_status of the outer onion, return trampoline_onion to be forwarded

trampoline MPP: fix total_msat in trampoline onion, and bucketing

2021-03-04T09:05:09Z

commit ba4d6bc8b34d17a998c011276ef57aab7f0c5106 parent 253907fb606f131a9cbd76743b137d744421b2f3 Author: ThomasV Date: Thu, 4 Mar 2021 10:05:09 +0100 trampoline MPP: fix total_msat in trampoline onion, and bucketing

lnworker: move buckets logic inside first branch of if statement (refactoring commit)

2021-03-04T07:50:22Z

commit 253907fb606f131a9cbd76743b137d744421b2f3 parent f84f13529af30a9175f7011dde9bdca96e7f6f8d Author: ThomasV Date: Thu, 4 Mar 2021 08:50:22 +0100 lnworker: move buckets logic inside first branch of if statement (refactoring commit)

lnhtlc: fix deadlock

2021-03-03T21:05:09Z

commit f84f13529af30a9175f7011dde9bdca96e7f6f8d parent adbfb2dcc84f015225c63bd239153314bbec05d5 Author: SomberNight Date: Wed, 3 Mar 2021 22:05:09 +0100 lnhtlc: fix deadlock

lnworker.pay_to_node: (fix) pass correct total_msat to pay_to_route

2021-03-03T19:35:48Z

commit adbfb2dcc84f015225c63bd239153314bbec05d5 parent 920e1e94fab9d1a39f8e5412bf4677bf9b63ef50 Author: SomberNight Date: Wed, 3 Mar 2021 20:35:48 +0100 lnworker.pay_to_node: (fix) pass correct total_msat to pay_to_route

kivy: InvoiceDialog: make LN invoice QR code scannable

2021-03-03T16:31:08Z

commit 920e1e94fab9d1a39f8e5412bf4677bf9b63ef50 parent 1aec982b27a7b12d51493a393849da4f4bccd10d Author: SomberNight Date: Wed, 3 Mar 2021 17:31:08 +0100 kivy: InvoiceDialog: make LN invoice QR code scannable Don't show the text and the QR code together, only the QR code: the text takes up too much space, which make the QR hard to scan.

kivy: SendScreen: reliably show LN payment attempt progress for invoice

2021-03-03T15:57:54Z

commit 1aec982b27a7b12d51493a393849da4f4bccd10d parent 7ca64ebbd8872e8ebe0b0c3849e2ec078e0dfcab Author: SomberNight Date: Wed, 3 Mar 2021 16:57:54 +0100 kivy: SendScreen: reliably show LN payment attempt progress for invoice

fix #7078

2021-03-03T14:35:00Z

commit 7ca64ebbd8872e8ebe0b0c3849e2ec078e0dfcab parent 95b7c976e001e0ab16185e5b61c257906fe2ca18 Author: ThomasV Date: Wed, 3 Mar 2021 15:35:00 +0100 fix #7078

lnrouter.get_distances: fix exception due to rare race

2021-03-03T13:10:57Z

commit 95b7c976e001e0ab16185e5b61c257906fe2ca18 parent 3fa1aed8cdc426ae4c929c5160e345e8826854ac Author: SomberNight Date: Wed, 3 Mar 2021 14:10:57 +0100 lnrouter.get_distances: fix exception due to rare race if the graph is being updated while the pathfinding is running, channel_info might be None here

add unit test for basic mpp

2021-03-03T11:52:52Z

commit 3fa1aed8cdc426ae4c929c5160e345e8826854ac parent ca6ecd56f2568220143e92250796d557244e06a8 Author: ThomasV Date: Wed, 3 Mar 2021 12:52:52 +0100 add unit test for basic mpp

fix route for non-trampoline MPP

2021-03-03T11:30:29Z

commit ca6ecd56f2568220143e92250796d557244e06a8 parent 1adde4c54aea2fbc71dedb93b51b7a24d1563a8f Author: ThomasV Date: Wed, 3 Mar 2021 12:30:29 +0100 fix route for non-trampoline MPP

qt channels_list: use monospace font for channel capacity

2021-03-03T10:20:24Z

commit 1adde4c54aea2fbc71dedb93b51b7a24d1563a8f parent 6cf79dcfb299420afa4c45fd4a03d3187bb484fe Author: ThomasV Date: Wed, 3 Mar 2021 11:20:24 +0100 qt channels_list: use monospace font for channel capacity

qt: update all tabs when base_unit changes

2021-03-03T10:19:41Z

commit 6cf79dcfb299420afa4c45fd4a03d3187bb484fe parent 222c70ada62cb49ab0949f4097e5819049bf7ede Author: ThomasV Date: Wed, 3 Mar 2021 11:19:41 +0100 qt: update all tabs when base_unit changes

qt swap_dialog: use a single button to toggle direction

2021-03-03T09:45:46Z

commit 222c70ada62cb49ab0949f4097e5819049bf7ede parent 51f3c613a5acad42268f10356ca74e6c47bc2b18 Author: ThomasV Date: Wed, 3 Mar 2021 10:45:46 +0100 qt swap_dialog: use a single button to toggle direction

(minor) fix typos and indentation

2021-03-03T09:03:29Z

commit 51f3c613a5acad42268f10356ca74e6c47bc2b18 parent 44059ec116ec32fca88348d4001fe94aef3e72c0 Author: ThomasV Date: Wed, 3 Mar 2021 10:03:29 +0100 (minor) fix typos and indentation

lnpeer: more detailed logging in maybe_fulfill_htlc

2021-03-02T17:53:08Z

commit 44059ec116ec32fca88348d4001fe94aef3e72c0 parent 9310e9023efa3015c677790a9d092df915e82755 Author: SomberNight Date: Tue, 2 Mar 2021 18:53:08 +0100 lnpeer: more detailed logging in maybe_fulfill_htlc