gettextprop: check result of XGetTextProperty (undefined behaviour for XFree) - dwm - dynamic window manager
HTML git clone https://git.parazyd.org/dwm
DIR Log
DIR Files
DIR Refs
DIR README
DIR LICENSE
---
DIR commit 99f78fa553f9ddb23fab73e47a408d66ca7f974c
DIR parent a9b6a312a77b9cc81ca8b08a95c09e9f7948d7a6
HTML Author: Hiltjo Posthuma <hiltjo@codemadness.org>
Date: Fri, 3 Nov 2017 16:36:32 +0100
gettextprop: check result of XGetTextProperty (undefined behaviour for XFree)
Diffstat:
M dwm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
---
DIR diff --git a/dwm.c b/dwm.c
@@ -910,8 +910,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size)
if (!text || size == 0)
return 0;
text[0] = '\0';
- XGetTextProperty(dpy, w, &name, atom);
- if (!name.nitems)
+ if (!XGetTextProperty(dpy, w, &name, atom) || !name.nitems)
return 0;
if (name.encoding == XA_STRING)
strncpy(text, (char *)name.value, size - 1);