tqt history: data() should return QVariant - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit 0ec7005f90d986d801a94a2038b5fab94d36cf70
DIR parent 4e7b2f3ea3a4b3df8f4f725f3bd87ae75c25cebe
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Mon, 10 Dec 2018 19:42:31 +0100
qt history: data() should return QVariant
tthe docs says so,
and also HistoryList.create_menu() was crashing sometimes re "Copy {}"
Diffstat:
M electrum/gui/qt/history_list.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
DIR diff --git a/electrum/gui/qt/history_list.py b/electrum/gui/qt/history_list.py
t@@ -105,7 +105,7 @@ class HistoryModel(QAbstractItemModel, PrintError):
def index(self, row: int, column: int, parent: QModelIndex):
return self.createIndex(row, column)
- def data(self, index: QModelIndex, role: Qt.ItemDataRole):
+ def data(self, index: QModelIndex, role: Qt.ItemDataRole) -> QVariant:
# note: this method is performance-critical.
# it is called a lot, and so must run extremely fast.
assert index.isValid()
t@@ -161,7 +161,7 @@ class HistoryModel(QAbstractItemModel, PrintError):
and not tx_item.get('fiat_default') and tx_item.get('fiat_value') is not None:
blue_brush = QBrush(QColor("#1E1EFF"))
return QVariant(blue_brush)
- return None
+ return QVariant()
if col == HistoryColumns.STATUS_TEXT:
return QVariant(status_str)
elif col == HistoryColumns.DESCRIPTION:
t@@ -187,7 +187,7 @@ class HistoryModel(QAbstractItemModel, PrintError):
return QVariant(self.parent.fx.format_fiat(cg))
elif col == HistoryColumns.TXID:
return QVariant(tx_hash)
- return None
+ return QVariant()
def parent(self, index: QModelIndex):
return QModelIndex()