tQt: keep pending_invoice logic in main_window (follow-up 56579c2, fixes #5829) - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit 1684b348dfaf6aa25a3d100f0781993b66deae9c
DIR parent f74ac1a74124a868bd48c75c405cd541d2ca470c
HTML Author: ThomasV <thomasv@electrum.org>
Date: Tue, 8 Dec 2020 13:12:57 +0100
Qt: keep pending_invoice logic in main_window (follow-up 56579c2, fixes #5829)
Diffstat:
M electrum/gui/qt/main_window.py | 35 ++++++++++++++++---------------
M electrum/gui/qt/transaction_dialog… | 1 +
2 files changed, 19 insertions(+), 17 deletions(-)
---
DIR diff --git a/electrum/gui/qt/main_window.py b/electrum/gui/qt/main_window.py
t@@ -188,6 +188,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger):
self.pluginsdialog = None
self.showing_cert_mismatch_error = False
self.tl_windows = []
+ self.pending_invoice = None
Logger.__init__(self)
self.tx_notification_queue = queue.Queue()
t@@ -1517,7 +1518,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger):
return False # no errors
- def pay_lightning_invoice(self, invoice: str, *, amount_msat: Optional[int], pending_invoice: Optional['Invoice']):
+ def pay_lightning_invoice(self, invoice: str, *, amount_msat: Optional[int]):
if amount_msat is None:
raise Exception("missing amount for LN invoice")
amount_sat = Decimal(amount_msat) / 1000
t@@ -1525,8 +1526,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger):
msg = _("Pay lightning invoice?") + '\n\n' + _("This will send {}?").format(self.format_amount_and_units(amount_sat))
if not self.question(msg):
return
- if pending_invoice:
- self.save_invoice(pending_invoice)
+ self.save_pending_invoice()
attempts = LN_NUM_PAYMENT_ATTEMPTS
def task():
self.wallet.lnworker.pay(invoice, amount_msat=amount_msat, attempts=attempts)
t@@ -1588,21 +1588,24 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger):
URI=self.payto_URI)
def do_save_invoice(self):
- invoice = self.read_invoice()
- if not invoice:
+ self.pending_invoice = self.read_invoice()
+ if not self.pending_invoice:
return
- self.save_invoice(invoice)
+ self.save_pending_invoice()
- def save_invoice(self, invoice):
+ def save_pending_invoice(self):
+ if not self.pending_invoice:
+ return
self.do_clear()
- self.wallet.save_invoice(invoice)
+ self.wallet.save_invoice(self.pending_invoice)
self.invoice_list.update()
+ self.pending_invoice = None
def do_pay(self):
- invoice = self.read_invoice()
- if not invoice:
+ self.pending_invoice = self.read_invoice()
+ if not self.pending_invoice:
return
- self.do_pay_invoice(invoice)
+ self.do_pay_invoice(self.pending_invoice)
def pay_multiple_invoices(self, invoices):
outputs = []
t@@ -1613,10 +1616,10 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger):
def do_pay_invoice(self, invoice: 'Invoice'):
if invoice.type == PR_TYPE_LN:
assert isinstance(invoice, LNInvoice)
- self.pay_lightning_invoice(invoice.invoice, amount_msat=invoice.get_amount_msat(), pending_invoice=invoice)
+ self.pay_lightning_invoice(invoice.invoice, amount_msat=invoice.get_amount_msat())
elif invoice.type == PR_TYPE_ONCHAIN:
assert isinstance(invoice, OnchainInvoice)
- self.pay_onchain_dialog(self.get_coins(), invoice.outputs, pending_invoice=invoice)
+ self.pay_onchain_dialog(self.get_coins(), invoice.outputs)
else:
raise Exception('unknown invoice type')
t@@ -1637,8 +1640,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger):
def pay_onchain_dialog(
self, inputs: Sequence[PartialTxInput],
outputs: List[PartialTxOutput], *,
- external_keypairs=None,
- pending_invoice: Optional['Invoice']) -> None:
+ external_keypairs=None) -> None:
# trustedcoin requires this
if run_hook('abort_send', self):
return
t@@ -1671,9 +1673,8 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger):
cancelled, is_send, password, tx = d.run()
if cancelled:
return
- if pending_invoice:
- self.save_invoice(pending_invoice)
if is_send:
+ self.save_pending_invoice()
def sign_done(success):
if success:
self.broadcast_or_show(tx)
DIR diff --git a/electrum/gui/qt/transaction_dialog.py b/electrum/gui/qt/transaction_dialog.py
t@@ -219,6 +219,7 @@ class BaseTxDialog(QDialog, MessageBoxMixin):
def do_broadcast(self):
self.main_window.push_top_level_window(self)
+ self.main_window.save_pending_invoice()
try:
self.main_window.broadcast_transaction(self.tx)
finally: