tQt tx dialog: show txid as "unknown" while not finalized - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit 3090cc68bb96d683e1e286781dba82e008611250
DIR parent 6f2cd8b4f53272dd3695fb9677907fa3a29be028
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Sun, 1 Mar 2020 09:32:05 +0100
Qt tx dialog: show txid as "unknown" while not finalized
Diffstat:
M electrum/gui/qt/transaction_dialog… | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
---
DIR diff --git a/electrum/gui/qt/transaction_dialog.py b/electrum/gui/qt/transaction_dialog.py
t@@ -417,7 +417,12 @@ class BaseTxDialog(QDialog, MessageBoxMixin):
can_sign = not self.tx.is_complete() and \
(self.wallet.can_sign(self.tx) or bool(self.external_keypairs))
self.sign_button.setEnabled(can_sign)
- self.tx_hash_e.setText(tx_details.txid or _('Unknown'))
+ if self.finalized and tx_details.txid:
+ self.tx_hash_e.setText(tx_details.txid)
+ else:
+ # note: when not finalized, RBF and locktime changes do not trigger
+ # a make_tx, so the txid is unreliable, hence:
+ self.tx_hash_e.setText(_('Unknown'))
if desc is None:
self.tx_desc.hide()
else: