tcosigner pool: easy fix (works but with worse than previous behaviour) - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit 34392e82b96fb44b337d991c6cb2eb5386c999b4
DIR parent 4313bde4c25021e58596c59fef57f8427514390f
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Fri, 7 Feb 2020 20:09:40 +0100
cosigner pool: easy fix (works but with worse than previous behaviour)
got broken as part of PSBT changes in #5721
Diffstat:
M electrum/plugins/cosigner_pool/qt.… | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
---
DIR diff --git a/electrum/plugins/cosigner_pool/qt.py b/electrum/plugins/cosigner_pool/qt.py
t@@ -164,12 +164,10 @@ class Plugin(BasePlugin):
d.cosigner_send_button.setVisible(False)
def cosigner_can_sign(self, tx: Transaction, cosigner_xpub: str) -> bool:
- if not isinstance(tx, PartialTransaction):
- return False
- if tx.is_complete():
- return False
- # TODO this is broken currently as it assumes tx.xpubs
- return cosigner_xpub in {bip32node.to_xpub() for bip32node in tx.xpubs}
+ # TODO implement this properly:
+ # should return True iff cosigner (with given xpub) can sign and has not yet signed.
+ # note that tx could also be unrelated from wallet?... (not ismine inputs)
+ return True
def do_send(self, tx: Union[Transaction, PartialTransaction]):
def on_success(result):