twallet: add FIXME re fiat coin_price calculation - electrum - Electrum Bitcoin wallet HTML git clone https://git.parazyd.org/electrum DIR Log DIR Files DIR Refs DIR Submodules --- DIR commit 99325618a6c6cf27e29fa6015359342d1b5268d0 DIR parent fc2972e977797e6f57908004eddb57f4fca19928 HTML Author: SomberNight <somber.night@protonmail.com> Date: Wed, 28 Nov 2018 15:52:38 +0100 wallet: add FIXME re fiat coin_price calculation Diffstat: M electrum/wallet.py | 3 +++ 1 file changed, 3 insertions(+), 0 deletions(-) --- DIR diff --git a/electrum/wallet.py b/electrum/wallet.py t@@ -1185,6 +1185,9 @@ class Abstract_Wallet(AddressSynchronizer): """ if txin_value is None: return Decimal('NaN') + # FIXME: this mutual recursion will be really slow and might even reach + # max recursion depth if there are no FX rates available as then + # nothing will be cached. cache_key = "{}:{}:{}".format(str(txid), str(ccy), str(txin_value)) result = self.coin_price_cache.get(cache_key, None) if result is not None: