tkivy: use on_release instead of on_press in buttons - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit afbdacbe16b236bc9c4e8a3a300578533daa6e20
DIR parent 212d18d5e6106f8598dfeafbd42e82e7048b65d1
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Thu, 25 Jun 2020 21:55:59 +0200
kivy: use on_release instead of on_press in buttons
I think on_release has better UX.
More importantly, on desktop linux with kivy 2.0.0rc2, on_press does not work for me.
(but on Android, with kivy 1.11.1, it does)
Diffstat:
M electrum/gui/kivy/uix/dialogs/cras… | 2 +-
M electrum/gui/kivy/uix/dialogs/ligh… | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
DIR diff --git a/electrum/gui/kivy/uix/dialogs/crash_reporter.py b/electrum/gui/kivy/uix/dialogs/crash_reporter.py
t@@ -36,7 +36,7 @@ Builder.load_string('''
text: 'Show report contents'
height: '48dp'
size_hint: 1, None
- on_press: root.show_contents()
+ on_release: root.show_contents()
BoxLayout:
size_hint: 1, 0.1
Label:
DIR diff --git a/electrum/gui/kivy/uix/dialogs/lightning_channels.py b/electrum/gui/kivy/uix/dialogs/lightning_channels.py
t@@ -94,7 +94,7 @@ Builder.load_string(r'''
size_hint: 0.3, None
height: '48dp'
text: _('New...')
- on_press: popup.app.popup_dialog('lightning_open_channel_dialog')
+ on_release: popup.app.popup_dialog('lightning_open_channel_dialog')
<ChannelDetailsPopup@Popup>: