thww: stop keystore.thread when closing wallet - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit b1d23896562d0311b3bbcb56588a67f99d76047c
DIR parent 2cfa3bd6c82b5f2df0332307240fd202523cb522
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Fri, 17 Apr 2020 19:37:05 +0200
hww: stop keystore.thread when closing wallet
previously left running? Qt on macOS was complaining:
```
QThread: Destroyed while thread is still running
Abort trap: 6
```
Diffstat:
M electrum/plugins/hw_wallet/plugin.… | 2 ++
1 file changed, 2 insertions(+), 0 deletions(-)
---
DIR diff --git a/electrum/plugins/hw_wallet/plugin.py b/electrum/plugins/hw_wallet/plugin.py
t@@ -81,6 +81,8 @@ class HW_PluginBase(BasePlugin):
for keystore in wallet.get_keystores():
if isinstance(keystore, self.keystore_class):
self.device_manager().unpair_xpub(keystore.xpub)
+ if keystore.thread:
+ keystore.thread.stop()
def scan_and_create_client_for_device(self, *, device_id: str, wizard: 'BaseWizard') -> 'HardwareClientBase':
devmgr = self.device_manager()