tHardwareClientBase: provide default implementation for label - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit bf067f7558657edd31b2dd7e6b30f0243cda528a
DIR parent db1ff4915fc613d30d4d73289337b38a2e2b0e2c
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Wed, 8 Apr 2020 18:28:21 +0200
HardwareClientBase: provide default implementation for label
and add warning about placeholders
Diffstat:
M electrum/plugins/digitalbitbox/dig… | 4 ----
M electrum/plugins/hw_wallet/plugin.… | 4 +++-
M electrum/plugins/ledger/ledger.py | 3 ---
3 files changed, 3 insertions(+), 8 deletions(-)
---
DIR diff --git a/electrum/plugins/digitalbitbox/digitalbitbox.py b/electrum/plugins/digitalbitbox/digitalbitbox.py
t@@ -88,10 +88,6 @@ class DigitalBitbox_Client(HardwareClientBase):
pass
- def label(self):
- return " "
-
-
def is_pairable(self):
return True
DIR diff --git a/electrum/plugins/hw_wallet/plugin.py b/electrum/plugins/hw_wallet/plugin.py
t@@ -196,7 +196,9 @@ class HardwareClientBase:
and they are also used as a fallback to distinguish devices programmatically.
So ideally, different devices would have different labels.
"""
- raise NotImplementedError()
+ # When returning a constant here (i.e. not implementing the method in the way
+ # it is supposed to work), make sure the return value is in electrum.plugin.PLACEHOLDER_HW_CLIENT_LABELS
+ return " "
def get_soft_device_id(self) -> Optional[str]:
"""An id-like string that is used to distinguish devices programmatically.
DIR diff --git a/electrum/plugins/ledger/ledger.py b/electrum/plugins/ledger/ledger.py
t@@ -80,9 +80,6 @@ class Ledger_Client(HardwareClientBase):
def is_initialized(self):
return True
- def label(self):
- return ""
-
def get_soft_device_id(self):
if self._soft_device_id is None:
# modern ledger can provide xpub without user interaction