tln: qt channel open: fix max channel size - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit cd9477c0da88288c6b92f430b533bf3026c84b67
DIR parent ae04434206525b1ec55127b9e752a330c5dbde5f
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Wed, 20 Nov 2019 17:45:28 +0100
ln: qt channel open: fix max channel size
Diffstat:
M electrum/gui/qt/channels_list.py | 8 +++++++-
M electrum/lnutil.py | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
---
DIR diff --git a/electrum/gui/qt/channels_list.py b/electrum/gui/qt/channels_list.py
t@@ -202,6 +202,12 @@ class ChannelsList(MyTreeView):
remote_nodeid.setCursorPosition(0)
if not d.exec_():
return
- funding_sat = '!' if max_button.isChecked() else amount_e.get_amount()
+ if max_button.isChecked() and amount_e.get_amount() < LN_MAX_FUNDING_SAT:
+ # if 'max' enabled and amount is strictly less than max allowed,
+ # that means we have fewer coins than max allowed, and hence we can
+ # spend all coins
+ funding_sat = '!'
+ else:
+ funding_sat = amount_e.get_amount()
connect_str = str(remote_nodeid.text()).strip()
self.parent.open_channel(connect_str, funding_sat, 0)
DIR diff --git a/electrum/lnutil.py b/electrum/lnutil.py
t@@ -27,7 +27,7 @@ if TYPE_CHECKING:
HTLC_TIMEOUT_WEIGHT = 663
HTLC_SUCCESS_WEIGHT = 703
-LN_MAX_FUNDING_SAT = pow(2, 24)
+LN_MAX_FUNDING_SAT = pow(2, 24) - 1
# dummy address for fee estimation of funding tx
def ln_dummy_address():