tqt TxDialog: visibility of widgets should be set after parenting - electrum - Electrum Bitcoin wallet HTML git clone https://git.parazyd.org/electrum DIR Log DIR Files DIR Refs DIR Submodules --- DIR commit dbd1c8cf71877dbca03501c07848655fdcf1a5bf DIR parent c9ede074629a4bbb02f94522a32469d5a5eaeadb HTML Author: SomberNight <somber.night@protonmail.com> Date: Thu, 12 Dec 2019 21:31:30 +0100 qt TxDialog: visibility of widgets should be set after parenting widget.show() and widget.setVisible(True) results in a blink of an ephemeral window containing the widget; tthat is, unless the widget has a parent explicitly set or it can be determined via which layout the widget is placed in. Diffstat: M electrum/gui/qt/transaction_dialog… | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- DIR diff --git a/electrum/gui/qt/transaction_dialog.py b/electrum/gui/qt/transaction_dialog.py t@@ -558,8 +558,6 @@ class BaseTxDialog(QDialog, MessageBoxMixin): self.rbf_cb = QCheckBox(_('Replace by fee')) self.rbf_cb.setChecked(bool(self.config.get('use_rbf', True))) vbox_right.addWidget(self.rbf_cb) - self.rbf_label.setVisible(self.finalized) - self.rbf_cb.setVisible(not self.finalized) self.locktime_label = TxDetailLabel() vbox_right.addWidget(self.locktime_label) t@@ -572,6 +570,10 @@ class BaseTxDialog(QDialog, MessageBoxMixin): vbox.addLayout(hbox_stats) + # set visibility after parenting can be determined by Qt + self.rbf_label.setVisible(self.finalized) + self.rbf_cb.setVisible(not self.finalized) + def set_title(self): self.setWindowTitle(_("Create transaction") if not self.finalized else _("Transaction"))