tqt ConfirmTxDialog: don't catch BaseException for make_tx - electrum - Electrum Bitcoin wallet
HTML git clone https://git.parazyd.org/electrum
DIR Log
DIR Files
DIR Refs
DIR Submodules
---
DIR commit e0eb3c18eb0d399f5b6f37bb9b3d54a368978203
DIR parent a6aa97c3e3a248f24a3e0c5d85f1f48bac230af2
HTML Author: SomberNight <somber.night@protonmail.com>
Date: Fri, 6 Dec 2019 20:41:51 +0100
qt ConfirmTxDialog: don't catch BaseException for make_tx
not sure what it is supposed to catch...
The examples I could come up with would all be actual bugs;
in which case we should let the exception propagate out to the crash reporter.
Diffstat:
M electrum/gui/qt/confirm_tx_dialog.… | 5 -----
1 file changed, 0 insertions(+), 5 deletions(-)
---
DIR diff --git a/electrum/gui/qt/confirm_tx_dialog.py b/electrum/gui/qt/confirm_tx_dialog.py
t@@ -99,11 +99,6 @@ class TxEditor:
self.tx = None
self.main_window.show_error(str(e))
raise
- except BaseException as e:
- self.tx = None
- self.main_window.logger.exception('')
- self.show_message(str(e))
- return
use_rbf = bool(self.config.get('use_rbf', True))
if use_rbf:
self.tx.set_rbf(True)