Subj : Re: JS script cleanup/formatting To : Tracker1 From : Digital Man Date : Thu Nov 05 2020 04:32 pm Re: Re: JS script cleanup/formatting By: Tracker1 to Tracker1 on Thu Nov 05 2020 10:59 am > On 10/29/2020 8:45 PM, Tracker1 wrote: > > Any thoughts on cleaning up the JS files and running through a > > linter/formatter for a consistent formatting? linting and formatting are 2 very different things. > > 1. There are some .js files that have hard coded CP437 characters in > > them, these should be changed to use at least escape codes instead of > > the characters directly (octal or hex). By doing this, the files should > > be able to be read with UTF8 editors without issue. Definitely not octal. I don't doubt this, but can you cite specific examples? Feel free to submit a merge request which addresses this (one specific thing). > > 2. Would be nice to agree upon a standard format and linting for > > formatting... most likely eslint with either prettier, standard, airbnb, > > and/or other format options. I would suggest 2 spaces for indentation, > > as this is what the broader JS community has adopted in most libraries. Defintely not 2 spaces. I don't care what "the broader JS community" has adopted. I prefer to keep the style similar to the prevailing C/C++ style in sbbs that that is very unlikely to align with "the broader JS community". > > 3. Would be a followup to address linting issues that don't meet > > auto-formatting. White space changes should not affect linting. -- digital man Sling Blade quote #4: Doyle: wimpy-ass kids or mental retards.. she got one of each livin' with her. Norco, CA WX: 66.0øF, 69.0% humidity, 5 mph E wind, 0.00 inches rain/24hrs .