Subj : src/sbbs3/ftpsrvr.c mailsrvr.c services.c websrvr.c To : Git commit to main/sbbs/master From : Rob Swindell (on Windows 11) Date : Tue Jan 16 2024 03:45 pm https://gitlab.synchro.net/main/sbbs/-/commit/0b1b1a6fa46caa05d7bd5239 Modified Files: src/sbbs3/ftpsrvr.c mailsrvr.c services.c websrvr.c Log Message: Fix issue with "Pause Logging" buttons not staying pressed in sbbsctrl-win32 Reported by Max (WESTLINE)... Introduced in commit 63d0772d, since we are now calling the set_state() callback periodically, and in sbbsctrl, it sets/resets the pause button checked (depressed) state in response to this callback (should it?), this was resetting the pause button checked/depressed state peridically (at the configured sem file check interval, default 2 seconds). The fix: if the new server state is the same as the previously set server state, don't call the set_state() callback. I considered this as a potential optimization when I first wrote that commit, but didn't see any obvious downside to calling the set_state() callback redundantly. Now that I see a downside, let's implement this saving/checking of the state to avoid redundant "set" calls. .